Merge pull request #14382 from topimiettinen/fix-analyze-security-rootimage

analyze: badness if neither of RootImage and RootDirectory exists
2019-12-18 16:21:36 -08:00 · 2019-12-18 20:38:04 +02:00
1 changed files with 1 additions and 1 deletions
--- a/src/analyze/analyze-security.c
+++ b/src/analyze/analyze-security.c
@ -306,7 +306,7 @@ static int assess_root_directory(
        assert(ret_description);
        *ret_badness =
-                empty_or_root(info->root_directory) ||
+                empty_or_root(info->root_directory) &&
                empty_or_root(info->root_image);
        *ret_description = NULL;
Author	SHA1	Message	Date
Anita Zhang	9a1b3902ad	Merge pull request #14382 from topimiettinen/fix-analyze-security-rootimage analyze: badness if neither of RootImage and RootDirectory exists	2019-12-18 16:21:36 -08:00
Topi Miettinen	d909b40fda	analyze: badness if neither of RootImage and RootDirectory exists Instead of requiring both RootImage and RootDirectory directives, give badness points if neither is present. Fixes conversion in `d737b451f`.	2019-12-18 20:38:04 +02:00