.mkosi/mkosi.fedora

@@ -5,7 +5,7 @@
 
 [Distribution]
 Distribution=fedora
-Release=34
+Release=33
 
 [Packages]
 BuildPackages=
@@ -52,6 +52,8 @@ BuildPackages=
         p11-kit-devel
         pam-devel
         pcre2-devel
+        perl(IPC::SysV)
+        perl(Time::HiRes)
         pkgconfig
         python3-devel
         python3-lxml

docs/TRANSIENT-SETTINGS.md

@@ -68,7 +68,6 @@ Most generic unit settings are available for transient units.
 ✓ ConditionKernelCommandLine=
 ✓ ConditionKernelVersion=
 ✓ ConditionArchitecture=
-✓ ConditionFirmware=
 ✓ ConditionVirtualization=
 ✓ ConditionSecurity=
 ✓ ConditionCapability=

hwdb.d/60-keyboard.hwdb

@@ -384,7 +384,7 @@ evdev:name:Dell WMI hotkeys:dmi:bvn*:bvr*:bd*:svnDell*:pnPrecision*:*
 
 # Dell Latitude privacy microphone mute
 evdev:name:Dell Privacy Driver:dmi:bvn*:bvr*:bd*:svnDell*:pnLatitude*:*
- KEYBOARD_KEY_120001=f20                                # Mic mute toggle, should be micmute
+ KEYBOARD_KEY_12001=f20                                 # Mic mute toggle, should be micmute
 
 ###########################################################
 # Everex

man/custom-entities.ent.in

@@ -11,5 +11,5 @@
 <!ENTITY KILL_USER_PROCESSES @KILL_USER_PROCESSES_YES_NO@>
 <!ENTITY DEBUGTTY @DEBUGTTY@>
 <!ENTITY RC_LOCAL_PATH @RC_LOCAL_PATH@>
-<!ENTITY fedora_latest_version "34">
+<!ENTITY fedora_latest_version "33">
 <!ENTITY fedora_cloud_release "1.2">

man/systemd.link.xml

@@ -222,18 +222,6 @@
           </para>
         </listitem>
       </varlistentry>
-
-      <varlistentry id='firmware'>
-        <term><varname>Firmware=</varname></term>
-        <listitem>
-          <para>Checks whether the system is running on a machine with the specified firmware. See
-          <varname>ConditionFirmware=</varname> in
-          <citerefentry><refentrytitle>systemd.unit</refentrytitle><manvolnum>5</manvolnum></citerefentry>
-          for details. When prefixed with an exclamation mark (<literal>!</literal>), the result is negated.
-          If an empty string is assigned, then previously assigned value is cleared.
-          </para>
-        </listitem>
-      </varlistentry>
     </variablelist>
 
   </refsect1>

man/systemd.netdev.xml

@@ -258,17 +258,6 @@
           </para>
         </listitem>
       </varlistentry>
-      <varlistentry>
-        <term><varname>Firmware=</varname></term>
-        <listitem>
-          <para>Checks whether the system is running on a machine with the specified firmware. See
-          <literal>ConditionFirmware=</literal> in
-          <citerefentry><refentrytitle>systemd.unit</refentrytitle><manvolnum>5</manvolnum></citerefentry>
-          for details. When prefixed with an exclamation mark (<literal>!</literal>), the result is negated.
-          If an empty string is assigned, then previously assigned value is cleared.
-          </para>
-        </listitem>
-      </varlistentry>
     </variablelist>
   </refsect1>
 

man/systemd.unit.xml

@@ -1172,16 +1172,6 @@
           </listitem>
         </varlistentry>
 
-        <varlistentry>
-          <term><varname>ConditionFirmware=</varname></term>
-
-          <listitem><para>Check whether the system's firmware is of a certain type. Possible values are:
-          <literal>uefi</literal> (for systems with EFI),
-          <literal>device-tree</literal> (for systems with a device tree) and
-          <literal>device-tree-compatible(xyz)</literal> (for systems with a device tree that is compatible to <literal>xyz</literal>).</para>
-          </listitem>
-        </varlistentry>
-
         <varlistentry>
           <term><varname>ConditionVirtualization=</varname></term>
 

meson.build

@@ -3168,7 +3168,7 @@ if conf.get('ENABLE_TMPFILES') == 1
 endif
 
 if conf.get('ENABLE_HWDB') == 1
-        systemd_hwdb = executable(
+        public_programs += executable(
                 'systemd-hwdb',
                 'src/hwdb/hwdb.c',
                 include_directories : includes,
@@ -3176,14 +3176,6 @@ if conf.get('ENABLE_HWDB') == 1
                 install_rpath : udev_rpath,
                 install : true,
                 install_dir : rootbindir)
-        public_programs += systemd_hwdb
-
-        if want_tests != 'false'
-                test('hwdb-test',
-                     hwdb_test_sh,
-                     args : [systemd_hwdb.full_path()],
-                     timeout : 90)
-        endif
 endif
 
 if conf.get('ENABLE_QUOTACHECK') == 1

src/core/load-fragment-gperf.gperf.m4

@@ -297,7 +297,6 @@ Unit.ConditionFileIsExecutable,          config_parse_unit_condition_path,
 Unit.ConditionNeedsUpdate,               config_parse_unit_condition_path,            CONDITION_NEEDS_UPDATE,             offsetof(Unit, conditions)
 Unit.ConditionFirstBoot,                 config_parse_unit_condition_string,          CONDITION_FIRST_BOOT,               offsetof(Unit, conditions)
 Unit.ConditionArchitecture,              config_parse_unit_condition_string,          CONDITION_ARCHITECTURE,             offsetof(Unit, conditions)
-Unit.ConditionFirmware,                  config_parse_unit_condition_string,          CONDITION_FIRMWARE,                 offsetof(Unit, conditions)
 Unit.ConditionVirtualization,            config_parse_unit_condition_string,          CONDITION_VIRTUALIZATION,           offsetof(Unit, conditions)
 Unit.ConditionHost,                      config_parse_unit_condition_string,          CONDITION_HOST,                     offsetof(Unit, conditions)
 Unit.ConditionKernelCommandLine,         config_parse_unit_condition_string,          CONDITION_KERNEL_COMMAND_LINE,      offsetof(Unit, conditions)

src/login/logind-dbus.c

@@ -1319,9 +1319,18 @@ static int trigger_device(Manager *m, sd_device *d) {
         }
 
         FOREACH_DEVICE(e, d) {
-                r = sd_device_trigger(d, SD_DEVICE_CHANGE);
+                _cleanup_free_ char *t = NULL;
+                const char *p;
+
+                r = sd_device_get_syspath(d, &p);
                 if (r < 0)
-                        log_device_debug_errno(d, r, "Failed to trigger device, ignoring: %m");
+                        return r;
+
+                t = path_join(p, "uevent");
+                if (!t)
+                        return -ENOMEM;
+
+                (void) write_string_file(t, "change", WRITE_STRING_FILE_DISABLE_BUFFER);
         }
 
         return 0;

src/network/netdev/netdev-gperf.gperf

@@ -44,7 +44,6 @@ Match.Virtualization,                     config_parse_net_condition,
 Match.KernelCommandLine,                  config_parse_net_condition,                CONDITION_KERNEL_COMMAND_LINE, offsetof(NetDev, conditions)
 Match.KernelVersion,                      config_parse_net_condition,                CONDITION_KERNEL_VERSION,      offsetof(NetDev, conditions)
 Match.Architecture,                       config_parse_net_condition,                CONDITION_ARCHITECTURE,        offsetof(NetDev, conditions)
-Match.Firmware,                           config_parse_net_condition,                CONDITION_FIRMWARE,            offsetof(NetDev, conditions)
 NetDev.Description,                       config_parse_string,                       0,                             offsetof(NetDev, description)
 NetDev.Name,                              config_parse_ifname,                       0,                             offsetof(NetDev, ifname)
 NetDev.Kind,                              config_parse_netdev_kind,                  0,                             offsetof(NetDev, kind)

src/network/networkd-network-gperf.gperf

@@ -56,7 +56,6 @@ Match.Virtualization,                        config_parse_net_condition,
 Match.KernelCommandLine,                     config_parse_net_condition,                               CONDITION_KERNEL_COMMAND_LINE, offsetof(Network, conditions)
 Match.KernelVersion,                         config_parse_net_condition,                               CONDITION_KERNEL_VERSION,      offsetof(Network, conditions)
 Match.Architecture,                          config_parse_net_condition,                               CONDITION_ARCHITECTURE,        offsetof(Network, conditions)
-Match.Firmware,                              config_parse_net_condition,                               CONDITION_FIRMWARE,            offsetof(Network, conditions)
 Link.MACAddress,                             config_parse_hwaddr,                                      0,                             offsetof(Network, mac)
 Link.MTUBytes,                               config_parse_mtu,                                         AF_UNSPEC,                     offsetof(Network, mtu)
 Link.Group,                                  config_parse_uint32,                                      0,                             offsetof(Network, group)

src/shared/condition.c

@@ -5,7 +5,6 @@
 #include <fnmatch.h>
 #include <limits.h>
 #include <stdlib.h>
-#include <sys/stat.h>
 #include <sys/types.h>
 #include <sys/utsname.h>
 #include <time.h>
@@ -451,81 +450,6 @@ static int condition_test_architecture(Condition *c, char **env) {
         return a == b;
 }
 
-#define DTCOMPAT_FILE "/sys/firmware/devicetree/base/compatible"
-static int condition_test_firmware_devicetree_compatible(const char *dtcarg) {
-        int r;
-        _cleanup_free_ char *dtcompat = NULL;
-        _cleanup_strv_free_ char **dtcompatlist = NULL;
-        size_t size;
-
-        r = read_full_virtual_file(DTCOMPAT_FILE, &dtcompat, &size);
-        if (r < 0) {
-                /* if the path doesn't exist it is incompatible */
-                if (r != -ENOENT)
-                        log_debug_errno(r, "Failed to open() '%s', assuming machine is incompatible: %m", DTCOMPAT_FILE);
-                return false;
-        }
-
-        /* Not sure this can happen, but play safe. */
-        if (size == 0) {
-                log_debug("%s has zero length, assuming machine is incompatible", DTCOMPAT_FILE);
-                return false;
-        }
-
-        /*
-         * /sys/firmware/devicetree/base/compatible consists of one or more
-         * strings, each ending in '\0'. So the last character in dtcompat must
-         * be a '\0'.
-         */
-        if (dtcompat[size - 1] != '\0') {
-                log_debug("%s is in an unknown format, assuming machine is incompatible", DTCOMPAT_FILE);
-                return false;
-        }
-
-        dtcompatlist = strv_parse_nulstr(dtcompat, size);
-        if (!dtcompatlist)
-                return -ENOMEM;
-
-        return strv_contains(dtcompatlist, dtcarg);
-}
-
-static int condition_test_firmware(Condition *c, char **env) {
-        sd_char *dtc;
-
-        assert(c);
-        assert(c->parameter);
-        assert(c->type == CONDITION_FIRMWARE);
-
-        if (streq(c->parameter, "device-tree")) {
-                if (access("/sys/firmware/device-tree/", F_OK) < 0) {
-                        if (errno != ENOENT)
-                                log_debug_errno(errno, "Unexpected error when checking for /sys/firmware/device-tree/: %m");
-                        return false;
-                } else
-                        return true;
-        } else if ((dtc = startswith(c->parameter, "device-tree-compatible("))) {
-                _cleanup_free_ char *dtcarg = NULL;
-                char *end;
-
-                end = strchr(dtc, ')');
-                if (!end || *(end + 1) != '\0') {
-                        log_debug("Malformed Firmware condition \"%s\"", c->parameter);
-                        return false;
-                }
-
-                dtcarg = strndup(dtc, end - dtc);
-                if (!dtcarg)
-                        return -ENOMEM;
-
-                return condition_test_firmware_devicetree_compatible(dtcarg);
-        } else if (streq(c->parameter, "uefi"))
-                return is_efi_boot();
-        else {
-                log_debug("Unsupported Firmware condition \"%s\"", c->parameter);
-                return false;
-        }
-}
-
 static int condition_test_host(Condition *c, char **env) {
         _cleanup_free_ char *h = NULL;
         sd_id128_t x, y;
@@ -919,7 +843,6 @@ int condition_test(Condition *c, char **env) {
                 [CONDITION_HOST]                     = condition_test_host,
                 [CONDITION_AC_POWER]                 = condition_test_ac_power,
                 [CONDITION_ARCHITECTURE]             = condition_test_architecture,
-                [CONDITION_FIRMWARE]                 = condition_test_firmware,
                 [CONDITION_NEEDS_UPDATE]             = condition_test_needs_update,
                 [CONDITION_FIRST_BOOT]               = condition_test_first_boot,
                 [CONDITION_USER]                     = condition_test_user,
@@ -1026,7 +949,6 @@ void condition_dump_list(Condition *first, FILE *f, const char *prefix, conditio
 
 static const char* const condition_type_table[_CONDITION_TYPE_MAX] = {
         [CONDITION_ARCHITECTURE] = "ConditionArchitecture",
-        [CONDITION_FIRMWARE] = "ConditionFirmware",
         [CONDITION_VIRTUALIZATION] = "ConditionVirtualization",
         [CONDITION_HOST] = "ConditionHost",
         [CONDITION_KERNEL_COMMAND_LINE] = "ConditionKernelCommandLine",
@@ -1059,7 +981,6 @@ DEFINE_STRING_TABLE_LOOKUP(condition_type, ConditionType);
 
 static const char* const assert_type_table[_CONDITION_TYPE_MAX] = {
         [CONDITION_ARCHITECTURE] = "AssertArchitecture",
-        [CONDITION_FIRMWARE] = "AssertFirmware",
         [CONDITION_VIRTUALIZATION] = "AssertVirtualization",
         [CONDITION_HOST] = "AssertHost",
         [CONDITION_KERNEL_COMMAND_LINE] = "AssertKernelCommandLine",

src/shared/condition.h

@@ -9,7 +9,6 @@
 
 typedef enum ConditionType {
         CONDITION_ARCHITECTURE,
-        CONDITION_FIRMWARE,
         CONDITION_VIRTUALIZATION,
         CONDITION_HOST,
         CONDITION_KERNEL_COMMAND_LINE,

src/shared/dissect-image.c

@@ -432,6 +432,7 @@ static int device_wait_for_initialization_harder(
                 usec_t deadline,
                 sd_device **ret) {
 
+        _cleanup_free_ char *uevent = NULL;
         usec_t start, left, retrigger_timeout;
         int r;
 
@@ -443,8 +444,7 @@ static int device_wait_for_initialization_harder(
                 const char *sn = NULL;
 
                 (void) sd_device_get_sysname(device, &sn);
-                log_device_debug(device,
-                                 "Waiting for device '%s' to initialize for %s.", strna(sn), format_timespan(buf, sizeof(buf), left, 0));
+                log_debug("Waiting for device '%s' to initialize for %s.", strna(sn), format_timespan(buf, sizeof(buf), left, 0));
         }
 
         if (left != USEC_INFINITY)
@@ -475,24 +475,33 @@ static int device_wait_for_initialization_harder(
                         const char *sn = NULL;
 
                         (void) sd_device_get_sysname(device, &sn);
-                        log_device_debug(device,
-                                         "Successfully waited for device '%s' to initialize for %s.",
-                                         strna(sn),
-                                         format_timespan(buf, sizeof(buf), usec_sub_unsigned(now(CLOCK_MONOTONIC), start), 0));
+                        log_debug("Successfully waited for device '%s' to initialize for %s.", strna(sn), format_timespan(buf, sizeof(buf), usec_sub_unsigned(now(CLOCK_MONOTONIC), start), 0));
 
                 }
                 if (r != -ETIMEDOUT || last_try)
                         return r;
 
+                if (!uevent) {
+                        const char *syspath;
+
+                        r = sd_device_get_syspath(device, &syspath);
+                        if (r < 0)
+                                return r;
+
+                        uevent = path_join(syspath, "uevent");
+                        if (!uevent)
+                                return -ENOMEM;
+                }
+
                 if (DEBUG_LOGGING) {
                         char buf[FORMAT_TIMESPAN_MAX];
 
-                        log_device_debug(device,
-                                         "Device didn't initialize within %s, assuming lost event. Retriggering device.",
-                                         format_timespan(buf, sizeof(buf), usec_sub_unsigned(now(CLOCK_MONOTONIC), start), 0));
+                        log_debug("Device didn't initialize within %s, assuming lost event. Retriggering device through %s.",
+                                  format_timespan(buf, sizeof(buf), usec_sub_unsigned(now(CLOCK_MONOTONIC), start), 0),
+                                  uevent);
                 }
 
-                r = sd_device_trigger(device, SD_DEVICE_CHANGE);
+                r = write_string_file(uevent, "change", WRITE_STRING_FILE_DISABLE_BUFFER);
                 if (r < 0)
                         return r;
         }

test/fuzz/fuzz-netdev-parser/directives.netdev

@@ -22,7 +22,6 @@ Mode=
 SourceMACAddress=
 [Match]
 Architecture=
-Firmware=
 Host=
 KernelVersion=
 Virtualization=

test/fuzz/fuzz-network-parser/directives.network

@@ -18,7 +18,6 @@ KernelVersion=
 Type=
 Driver=
 Architecture=
-Firmware=
 Path=
 WLANInterfaceType=
 SSID=

test/fuzz/fuzz-unit-file/directives.service

@@ -36,7 +36,6 @@ CollectMode=
 ConditionACPower=
 ConditionArchitecture=
 ConditionCPUs=
-ConditionFirmware=
 ConditionCapability=
 ConditionControlGroupController=
 ConditionDirectoryNotEmpty=

test/hwdb-test.sh

@@ -11,10 +11,10 @@ set -e
 
 export SYSTEMD_LOG_LEVEL=info
 ROOTDIR=$(dirname $(dirname $(readlink -f $0)))
-SYSTEMD_HWDB="${1:?missing argument}"
+SYSTEMD_HWDB=./systemd-hwdb
 
 if [ ! -x "$SYSTEMD_HWDB" ]; then
-    echo "$SYSTEMD_HWDB is not executable" >&2
+    echo "$SYSTEMD_HWDB does not exist, please build first"
     exit 1
 fi
 

test/meson.build

@@ -57,8 +57,10 @@ if install_tests
 endif
 
 test_network_generator_conversion_sh = find_program('test-network-generator-conversion.sh')
+
+############################################################
+
 test_systemd_tmpfiles_py = find_program('test-systemd-tmpfiles.py')
-hwdb_test_sh = find_program('hwdb-test.sh')
 
 ############################################################
 
@@ -126,6 +128,17 @@ endif
 
 ############################################################
 
+if conf.get('ENABLE_HWDB') == 1
+        hwdb_test_sh = find_program('hwdb-test.sh')
+        if want_tests != 'false'
+                test('hwdb-test',
+                     hwdb_test_sh,
+                     timeout : 90)
+        endif
+endif
+
+############################################################
+
 if want_tests != 'false' and dmi_arches.contains(host_machine.cpu_family())
         udev_dmi_memory_id_test = find_program('udev-dmi-memory-id-test.sh')