1
0
mirror of https://github.com/systemd/systemd synced 2025-10-03 02:34:45 +02:00

Compare commits

...

4 Commits

Author SHA1 Message Date
Luca Boccassi
6c40197464 ci: stop triggering suse-specific package build on OBS
Packages are now unified as the fedora spec can cohexist with suse's
2025-08-08 18:46:07 +01:00
Luca Boccassi
71b6836638
network: fix segfault in setting bridge vlan (#38519) 2025-08-08 15:04:33 +01:00
Yu Watanabe
570210eb28 network/bridge-vlan: fix segfault
Fixes a bug introduced by 78738adf88ad288a6af37a1998adc749ac6b5f2d.
Fixes #38515.
2025-08-08 19:39:31 +09:00
Yu Watanabe
df75dd34f6 test-network: also save the current state of socket units for resolved and stop them
Silence the following waring:
```
Stopping 'systemd-resolved.service', but its triggering units are still active:
systemd-resolved-varlink.socket, systemd-resolved-monitor.socket
```

Follow-up for 0fa188307b1c286e7b86201b1cfb91014b970092.
2025-08-08 19:38:27 +09:00
3 changed files with 19 additions and 8 deletions

View File

@ -3,9 +3,6 @@ rebuild:
- trigger_services:
project: system:systemd
package: systemd
- trigger_services:
project: system:systemd
package: systemd-suse
filters:
event: push
branches:

View File

@ -245,7 +245,7 @@ int bridge_vlan_set_message(Link *link, sd_netlink_message *m, bool is_set) {
if (r < 0)
return r;
if (link->master_ifindex <= 0 || streq(link->kind, "bridge")) {
if (link->master_ifindex <= 0 || streq_ptr(link->kind, "bridge")) {
/* If the setting is requested in a .network file for a bridge master (or a physical master)
* interface, then BRIDGE_FLAGS_SELF flag needs to be set. */
r = sd_netlink_message_append_u16(m, IFLA_BRIDGE_FLAGS, BRIDGE_FLAGS_SELF);

View File

@ -427,6 +427,8 @@ def save_active_units():
'systemd-networkd.socket',
'systemd-networkd-varlink.socket',
'systemd-networkd.service',
'systemd-resolved-monitor.socket',
'systemd-resolved-varlink.socket',
'systemd-resolved.service',
'systemd-timesyncd.service',
'firewalld.service'
@ -436,19 +438,31 @@ def save_active_units():
active_units.append(u)
def restore_active_units():
has_socket = False
has_network_socket = False
has_resolve_socket = False
if 'systemd-networkd.socket' in active_units:
call('systemctl stop systemd-networkd.socket')
has_socket = True
has_network_socket = True
if 'systemd-networkd-varlink.socket' in active_units:
call('systemctl stop systemd-networkd-varlink.socket')
has_socket = True
has_network_socket = True
if has_socket:
if 'systemd-resolved-monitor.socket' in active_units:
call('systemctl stop systemd-resolved-monitor.socket')
has_resolve_socket = True
if 'systemd-resolved-varlink.socket' in active_units:
call('systemctl stop systemd-resolved-varlink.socket')
has_resolve_socket = True
if has_network_socket:
call('systemctl stop systemd-networkd.service')
if has_resolve_socket:
call('systemctl stop systemd-resolved.service')
for u in active_units:
call(f'systemctl restart {u}')