update TODO

format-table: introduce TABLE_UID/TABLE_GID to match TABLE_PID and use it

NEWS

@@ -126,7 +126,7 @@ CHANGES WITH 244 in spe:
           request prefix hints in the DHCPv6 solicitation.
 
         * The DHCPv4 server may be configured to send arbitrary options using
-          a new SendRawOption= setting.
+          a new SendOption= setting.
 
         * The DHCPv4 server may now be configured to emit SIP server list using
           the new EmitSIP= and SIP= settings.

TODO

@@ -23,11 +23,6 @@ Before v244:
   it for the env var, the bootctl verb and the EFI variable itself, clear up
   semantics.
 
-* Figure out a better name for the global per-unit-type drop-in dirs, it's
-  confusing when it comes to -.mount.d/ (is it a drop-in-dir for all mount
-  units, or one for the root mount?). Also, OOM handling in
-  service_unit_name_is_valid() is borked.
-
 Features:
 
 * socket units: allow creating a udev monitor socket with ListenDevices= or so,

src/login/inhibit.c

@@ -114,9 +114,9 @@ static int print_inhibitors(sd_bus *bus) {
 
                 r = table_add_many(table,
                                    TABLE_STRING, who,
-                                   TABLE_UINT32, uid,
+                                   TABLE_UID, (uid_t) uid,
                                    TABLE_STRING, strna(u),
-                                   TABLE_UINT32, pid,
+                                   TABLE_PID, (pid_t) pid,
                                    TABLE_STRING, strna(comm),
                                    TABLE_STRING, what,
                                    TABLE_STRING, why,

src/login/loginctl.c

@@ -184,7 +184,7 @@ static int list_sessions(int argc, char *argv[], void *userdata) {
 
                 r = table_add_many(table,
                                    TABLE_STRING, id,
-                                   TABLE_UINT32, uid,
+                                   TABLE_UID, (uid_t) uid,
                                    TABLE_STRING, user,
                                    TABLE_STRING, seat,
                                    TABLE_STRING, strna(tty));
@@ -243,7 +243,7 @@ static int list_users(int argc, char *argv[], void *userdata) {
                         break;
 
                 r = table_add_many(table,
-                                   TABLE_UINT32, uid,
+                                   TABLE_UID, (uid_t) uid,
                                    TABLE_STRING, user);
                 if (r < 0)
                         return log_error_errno(r, "Failed to add row to table: %m");

src/shared/format-table.h

@@ -53,6 +53,12 @@ typedef enum TableDataType {
 #define TABLE_PID TABLE_INT32
 assert_cc(sizeof(pid_t) == sizeof(int32_t));
 
+/* UIDs/GIDs are just 32bit unsigned integers on Linux */
+#define TABLE_UID TABLE_UINT32
+#define TABLE_GID TABLE_UINT32
+assert_cc(sizeof(uid_t) == sizeof(uint32_t));
+assert_cc(sizeof(gid_t) == sizeof(uint32_t));
+
 typedef struct Table Table;
 typedef struct TableCell TableCell;