Merge pull request #20348 from poettering/free-and-replace-double-eval

make free_and_replace() double eval free

src/basic/alloc-util.h

@@ -51,9 +51,11 @@ static inline void *mfree(void *memory) {
 
 #define free_and_replace(a, b)                  \
         ({                                      \
-                free(a);                        \
+                typeof(a)* _a = &(a);           \
-                (a) = (b);                      \
+                typeof(b)* _b = &(b);           \
-                (b) = NULL;                     \
+                free(*_a);                      \
+                (*_a) = (*_b);                  \
+                (*_b) = NULL;                   \
                 0;                              \
         })
 

src/basic/strv.h

@@ -233,9 +233,11 @@ int fputstrv(FILE *f, char * const *l, const char *separator, bool *space);
 
 #define strv_free_and_replace(a, b)             \
         ({                                      \
-                strv_free(a);                   \
+                char ***_a = &(a);              \
-                (a) = (b);                      \
+                char ***_b = &(b);              \
-                (b) = NULL;                     \
+                strv_free(*_a);                 \
+                (*_a) = (*_b);                  \
+                (*_b) = NULL;                   \
                 0;                              \
         })
 

src/xdg-autostart-generator/xdg-autostart-service.c

@@ -416,8 +416,7 @@ int xdg_autostart_format_exec_start(
                         if (!escaped)
                                 return log_oom();
 
-                        free_and_replace(exec_split[n], escaped);
+                        free_and_replace(exec_split[n++], escaped);
-                        n++;
                         continue;
                 }
 
@@ -457,8 +456,7 @@ int xdg_autostart_format_exec_start(
                 if (!quoted)
                         return log_oom();
 
-                free_and_replace(exec_split[n], quoted);
+                free_and_replace(exec_split[n++], quoted);
-                n++;
         }
         for (; exec_split[n]; n++)
                 exec_split[n] = mfree(exec_split[n]);