docs/CODE_QUALITY.md

@@ -71,8 +71,5 @@ available functionality:
     See [Testing systemd using sanitizers](https://systemd.io/TESTING_WITH_SANITIZERS)
     for more information.
 
-16. Fossies provides [source code misspelling reports](https://fossies.org/features.html#codespell).
-    The systemd report can be found [here](https://fossies.org/linux/test/systemd-master.tar.gz/codespell.html).
-
 Access to Coverity and oss-fuzz reports is limited. Please reach out to the
 maintainers if you need access.

shell-completion/zsh/_resolvectl

@@ -53,10 +53,9 @@
         openpgp:"Retrieve openpgp keys for an email"
         query:"Resolve domain names, IPv4 and IPv6 addresses"
         reset-server-features:"Flushes all feature level information the resolver has learned about specific servers"
-        reset-statistics:"Resets the statistics counter shown in statistics to zero"
+        reset-statistics:"Resets the statistics counter show in statistics to zero"
         revert:"Revert the per-interfce DNS configuration"
         service:"Resolve DNS-SD and SRV services"
-        statistics:"Show resolver statistics"
         status:"Show the global and per-link DNS settings currently in effect"
         tlsa:"Query tlsa public keys stored as TLSA resource records"
     )
@@ -79,6 +78,10 @@ _arguments \
     '--service[Resolve services]' \
     '--service-address=no[Do not resolve address for services]' \
     '--service-txt=no[Do not resolve TXT records for services]' \
+    '--openpgp[Query OpenPGP public key]' \
+    '--tlsa[Query TLS public key]' \
     '--cname=no[Do not follow CNAME redirects]' \
     '--search=no[Do not use search domains]' \
+    '--statistics[Show resolver statistics]' \
+    '--reset-statistics[Reset resolver statistics]' \
     '*::default: _resolvectl_commands'

test/TEST-03-JOBS/test.sh

@@ -2,7 +2,6 @@
 set -e
 TEST_DESCRIPTION="Job-related tests"
 TEST_NO_QEMU=1
-IMAGE_NAME="default"
 
 . $TEST_BASE_DIR/test-functions
 

test/TEST-13-NSPAWN-SMOKE/test.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -e
 TEST_DESCRIPTION="systemd-nspawn smoke test"
-IMAGE_NAME="nspawn"
+IMAGE_NAME=nspawn
 TEST_NO_NSPAWN=1
 
 . $TEST_BASE_DIR/test-functions

test/TEST-14-MACHINE-ID/test.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -e
 TEST_DESCRIPTION="/etc/machine-id testing"
-IMAGE_NAME="badid"
+IMAGE_NAME=badid
 TEST_NO_NSPAWN=1
 
 . $TEST_BASE_DIR/test-functions

test/TEST-21-SYSUSERS/test.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -e
 TEST_DESCRIPTION="Sysuser-related tests"
-IMAGE_NAME="sysusers"
+IMAGE_NAME=sysusers
 . $TEST_BASE_DIR/test-functions
 
 test_setup() {

test/test-functions

@@ -18,7 +18,6 @@ EFI_MOUNT="${EFI_MOUNT:-$(bootctl -x 2>/dev/null || echo /boot)}"
 QEMU_MEM="${QEMU_MEM:-512M}"
 IMAGE_NAME=${IMAGE_NAME:-default}
 TEST_REQUIRE_INSTALL_TESTS="${TEST_REQUIRE_INSTALL_TESTS:-1}"
-TEST_PARALLELIZE="${TEST_PARALLELIZE:-0}"
 LOOPDEV=
 
 # Decide if we can (and want to) run QEMU with KVM acceleration.
@@ -330,13 +329,12 @@ systemd.wants=testsuite-$1.service ${_end} \
 $KERNEL_APPEND \
 "
 
-    [ -e "$IMAGE_PRIVATE" ] && image="$IMAGE_PRIVATE" || image="$IMAGE_PUBLIC"
     QEMU_OPTIONS="-smp $QEMU_SMP \
 -net none \
 -m $QEMU_MEM \
 -nographic \
 -kernel $KERNEL_BIN \
--drive format=raw,cache=unsafe,file=$image \
+-drive format=raw,cache=unsafe,file=${IMAGESTATEDIR}/${IMAGE_NAME}.img \
 $QEMU_OPTIONS \
 "
 
@@ -694,14 +692,16 @@ create_empty_image() {
         _size=$((4*_size))
     fi
 
-    echo "Setting up $IMAGE_PUBLIC (${_size} MB)"
+    image="${TESTDIR}/${IMAGE_NAME}.img"
-    rm -f "$IMAGE_PRIVATE" "$IMAGE_PUBLIC"
+    public="$IMAGESTATEDIR/${IMAGE_NAME}.img"
+    echo "Setting up $public (${_size} MB)"
+    rm -f "$image" "$public"
 
     # Create the blank file to use as a root filesystem
-    truncate -s "${_size}M" "$IMAGE_PRIVATE"
+    truncate -s "${_size}M" "$image"
-    ln -vs "$(realpath $IMAGE_PRIVATE)" "$IMAGE_PUBLIC"
+    ln -vs "$(realpath $image)" "$public"
 
-    LOOPDEV=$(losetup --show -P -f "$IMAGE_PUBLIC")
+    LOOPDEV=$(losetup --show -P -f "$public")
     [ -b "$LOOPDEV" ] || return 1
     sfdisk "$LOOPDEV" <<EOF
 ,$((_size-50))M
@@ -722,7 +722,7 @@ EOF
 
 mount_initdir() {
     if [ -z "${LOOPDEV}" ]; then
-        [ -e "$IMAGE_PRIVATE" ] && image="$IMAGE_PRIVATE" || image="$IMAGE_PUBLIC"
+        image="${IMAGESTATEDIR}/${IMAGE_NAME}.img"
         LOOPDEV=$(losetup --show -P -f "$image")
         [ -b "$LOOPDEV" ] || return 1
 
@@ -744,7 +744,8 @@ cleanup_initdir() {
 umount_loopback() {
     # unmount the loopback device from all places. Otherwise we risk file
     # system corruption.
-    for device in $(losetup -l | awk '$6=="'"$IMAGE_PUBLIC"'" {print $1}'); do
+    image="${IMAGESTATEDIR}/${IMAGE_NAME}.img"
+    for device in $(losetup -l | awk '$6=="'"$image"'" {print $1}'); do
         ddebug "Unmounting all uses of $device"
         mount | awk '/^'"${device}"'p/{print $1}' | xargs --no-run-if-empty umount -v
     done
@@ -1214,9 +1215,6 @@ TESTDIR="$TESTDIR"
 EOF
         export TESTDIR
     fi
-
-    IMAGE_PRIVATE="${TESTDIR}/${IMAGE_NAME}.img"
-    IMAGE_PUBLIC="${IMAGESTATEDIR}/${IMAGE_NAME}.img"
 }
 
 import_initdir() {
@@ -1966,7 +1964,7 @@ _test_cleanup() {
     (
         set +e
         _umount_dir $initdir
-        rm -vf "$IMAGE_PUBLIC"
+        rm -vf "${IMAGESTATEDIR}/${IMAGE_NAME}.img"
         rm -vfr "$TESTDIR"
         rm -vf "$STATEFILE"
     ) || :
@@ -2002,16 +2000,14 @@ test_setup() {
         exit 1
     fi
 
-    if [ -e "$IMAGE_PRIVATE" ]; then
+    image="${TESTDIR}/${IMAGE_NAME}.img"
-        echo "Reusing existing image $IMAGE_PRIVATE → $(realpath $IMAGE_PRIVATE)"
+    public="${IMAGESTATEDIR}/${IMAGE_NAME}.img"
+    if [ -e "$image" ]; then
+        echo "Reusing existing image $PWD/$image → $(realpath $image)"
         mount_initdir
-    elif [ -e "$IMAGE_PUBLIC" ]; then
+    elif [ -e "$public" ]; then
-        echo "Reusing existing cached image $IMAGE_PUBLIC → $(realpath $IMAGE_PUBLIC)"
+        echo "Reusing existing cached image $PWD/$public → $(realpath $public)"
-        if [ ${TEST_PARALLELIZE} -ne 0 ]; then
+        ln -s "$(realpath $public)" "$image"
-            cp -v "$(realpath $IMAGE_PUBLIC)" "$IMAGE_PRIVATE"
-        else
-            ln -sv "$(realpath $IMAGE_PUBLIC)" "$IMAGE_PRIVATE"
-        fi
         mount_initdir
     else
         test_create_image

tools/oss-fuzz.sh

@@ -27,15 +27,9 @@ build=$WORK/build
 rm -rf $build
 mkdir -p $build
 
+fuzzflag="oss-fuzz=true"
 if [ -z "$FUZZING_ENGINE" ]; then
     fuzzflag="llvm-fuzz=true"
-else
-    fuzzflag="oss-fuzz=true"
-    if [[ "$SANITIZER" == undefined ]]; then
-        UBSAN_FLAGS="-fsanitize=pointer-overflow -fno-sanitize-recover=pointer-overflow"
-        CFLAGS="$CFLAGS $UBSAN_FLAGS"
-        CXXFLAGS="$CXXFLAGS $UBSAN_FLAGS"
-    fi
 fi
 
 meson $build -D$fuzzflag -Db_lundef=false