Compare commits

...

9 Commits

Author SHA1 Message Date
Vishal Chillara c535f59462
Merge e9cfc2bd94 into 5261c521e3 2024-11-08 16:11:58 +01:00
Yu Watanabe 5261c521e3 mount-util: make path_get_mount_info() work arbitrary inode
Follow-up for d49d95df0a.
Replaces 9a032ec55a.
Fixes #35075.
2024-11-08 13:25:17 +01:00
Franck Bui 514d9e1665 test: install integration-test-setup.sh in testdata/
integration-test-setup.sh is an auxiliary script that tests rely on at
runtime. As such, install the script in testdata/.

Follow-up for af153e36ae.
2024-11-08 12:37:40 +01:00
Lennart Poettering b480a4c15e update TODO 2024-11-08 10:10:11 +01:00
Lennart Poettering af3baf174a fs-util: add comment about XO_NOCOW 2024-11-08 09:21:25 +01:00
Ryan Wilson d8091e1281 Fix PrivatePIDs=yes integration test for kernels with no /proc/scsi 2024-11-08 13:38:35 +09:00
Frantisek Sumsal e9cfc2bd94 varlinkctl: flush stdout after each record in --more mode
So things work correctly even if varlinkctl's output is redirected to a
file.
2024-10-29 22:44:13 +05:30
Vishal Chillara Srinivas 08860aa147 test: resolve: add testing for mDNS browse
Co-authored-by: Frantisek Sumsal <frantisek@sumsal.cz>
Co-authored-by: Vishwanath Chandapur <vishwanath.chandapur@philips.com>
2024-10-29 22:43:02 +05:30
Vishal Chillara Srinivas 2e5bf2774e resolved: Implement continuous mDNS querying as per RFC6762 5.2
Allow for mDNS service/domain/types browsing.
A client can connect to the backend via varlink and receive updates as the
requested service becomes available.
The interval between the first two queries MUST be at least one second,
the intervals between successive queries MUST increase by at least a factor of two.
When the interval between queries reaches or exceeds 60 minutes, a querier MAY cap
the interval to a maximum of 60 minutes, and perform subsequent queries at a
steady-state rate of one query per hour.
Delete expired cache entries one second after goodbye packet received
as per RFC6762 Section 10.1

Cache maintenance:
The querier should plan to issue a query at 80% of the record lifetime, and
then if no answer is received, at 85%, 90%, and 95%.
If an answer is received, then the remaining TTL is reset to the value given
in the answer, and this process repeats for as long as the Multicast DNS querier
has an ongoing interest in the record.
If no answer is received after four queries, the record is deleted when it
reaches 100% of its lifetime.

Co-authored-by: Vishwanath Chandapur <vishwanath.chandapur@philips.com>
2024-10-29 22:38:48 +05:30
30 changed files with 1418 additions and 111 deletions

25
TODO
View File

@ -129,6 +129,10 @@ Deprecations and removals:
Features: Features:
* format-table: introduce new cell type for strings with ansi sequences in
them. display them in regular output mode (via strip_tab_ansi()), but
suppress them in json mode.
* machined: when registering a machine, also take a relative cgroup path, * machined: when registering a machine, also take a relative cgroup path,
relative to the machine's unit. This is useful when registering unpriv relative to the machine's unit. This is useful when registering unpriv
machines, as they might sit down the cgroup tree, below a cgroup delegation machines, as they might sit down the cgroup tree, below a cgroup delegation
@ -217,12 +221,8 @@ Features:
services where mount propagation from the root fs is off, an still have services where mount propagation from the root fs is off, an still have
confext/sysext propagated in. confext/sysext propagated in.
* support F_DUDFD_QUERY for comparing fds in same_fd (requires kernel 6.10)
* generic interface for varlink for setting log level and stuff that all our daemons can implement * generic interface for varlink for setting log level and stuff that all our daemons can implement
* use pty ioctl to get peer wherever possible (TIOCGPTPEER)
* maybe teach repart.d/ dropins a new setting MakeMountNodes= or so, which is * maybe teach repart.d/ dropins a new setting MakeMountNodes= or so, which is
just like MakeDirectories=, but uses an access mode of 0000 and sets the +i just like MakeDirectories=, but uses an access mode of 0000 and sets the +i
chattr bit. This is useful as protection against early uses of /var/ or /tmp/ chattr bit. This is useful as protection against early uses of /var/ or /tmp/
@ -253,8 +253,6 @@ Features:
* initrd: when transitioning from initrd to host, validate that * initrd: when transitioning from initrd to host, validate that
/lib/modules/`uname -r` exists, refuse otherwise /lib/modules/`uname -r` exists, refuse otherwise
* tmpfiles: add "owning" flag for lines that limits effect of --purge
* signed bpf loading: to address need for signature verification for bpf * signed bpf loading: to address need for signature verification for bpf
programs when they are loaded, and given the bpf folks don't think this is programs when they are loaded, and given the bpf folks don't think this is
realistic in kernel space, maybe add small daemon that facilitates this realistic in kernel space, maybe add small daemon that facilitates this
@ -458,9 +456,6 @@ Features:
* introduce mntid_t, and make it 64bit, as apparently the kernel switched to * introduce mntid_t, and make it 64bit, as apparently the kernel switched to
64bit mount ids 64bit mount ids
* use udev rule networkd ownership property to take ownership of network
interfaces nspawn creates
* mountfsd/nsresourced * mountfsd/nsresourced
- userdb: maybe allow callers to map one uid to their own uid - userdb: maybe allow callers to map one uid to their own uid
- bpflsm: allow writes if resulting UID on disk would be userns' owner UID - bpflsm: allow writes if resulting UID on disk would be userns' owner UID
@ -647,6 +642,7 @@ Features:
- openpt_allocate_in_namespace() - openpt_allocate_in_namespace()
- unit_attach_pid_to_cgroup_via_bus() - unit_attach_pid_to_cgroup_via_bus()
- cg_attach() requires new kernel feature - cg_attach() requires new kernel feature
- journald's process cache
* ddi must be listed as block device fstype * ddi must be listed as block device fstype
@ -1470,9 +1466,6 @@ Features:
* in sd-id128: also parse UUIDs in RFC4122 URN syntax (i.e. chop off urn:uuid: prefix) * in sd-id128: also parse UUIDs in RFC4122 URN syntax (i.e. chop off urn:uuid: prefix)
* DynamicUser= + StateDirectory= → use uid mapping mounts, too, in order to
make dirs appear under right UID.
* systemd-sysext: optionally, run it in initrd already, before transitioning * systemd-sysext: optionally, run it in initrd already, before transitioning
into host, to open up possibility for services shipped like that. into host, to open up possibility for services shipped like that.
@ -1644,14 +1637,6 @@ Features:
* maybe add kernel cmdline params: to force random seed crediting * maybe add kernel cmdline params: to force random seed crediting
* introduce a new per-process uuid, similar to the boot id, the machine id, the
invocation id, that is derived from process creds, specifically a hashed
combination of AT_RANDOM + getpid() + the starttime from
/proc/self/status. Then add these ids implicitly when logging. Deriving this
uuid from these three things has the benefit that it can be derived easily
from /proc/$PID/ in a stable, and unique way that changes on both fork() and
exec().
* let's not GC a unit while its ratelimits are still pending * let's not GC a unit while its ratelimits are still pending
* when killing due to service watchdog timeout maybe detect whether target * when killing due to service watchdog timeout maybe detect whether target

View File

@ -1131,6 +1131,8 @@ int xopenat_full(int dir_fd, const char *path, int open_flags, XOpenFlags xopen_
* If O_CREAT is used with XO_LABEL, any created file will be immediately relabelled. * If O_CREAT is used with XO_LABEL, any created file will be immediately relabelled.
* *
* If the path is specified NULL or empty, behaves like fd_reopen(). * If the path is specified NULL or empty, behaves like fd_reopen().
*
* If XO_NOCOW is specified will turn on the NOCOW btrfs flag on the file, if available.
*/ */
if (isempty(path)) { if (isempty(path)) {

View File

@ -8,6 +8,7 @@ basic_dns_sources = files(
'resolved-dns-rr.c', 'resolved-dns-rr.c',
'resolved-dns-answer.c', 'resolved-dns-answer.c',
'resolved-dns-question.c', 'resolved-dns-question.c',
'resolved-dns-browse-services.c',
'resolved-util.c', 'resolved-util.c',
'dns-type.c', 'dns-type.c',
) )

View File

@ -0,0 +1,687 @@
/* SPDX-License-Identifier: LGPL-2.1-or-later */
#include "af-list.h"
#include "event-util.h"
#include "json-util.h"
#include "random-util.h"
#include "resolved-dns-browse-services.h"
#include "resolved-dns-cache.h"
#include "resolved-varlink.h"
/* RFC 6762 section 5.2 - The querier should plan to issue a query at 80% of
* the record lifetime, and then if no answer is received, at 85%, 90%, and 95%. */
static usec_t mdns_maintenance_next_time(usec_t until, uint32_t ttl, int ttl_state) {
return usec_sub_unsigned(until, (20 - ttl_state * 5) * ttl * USEC_PER_SEC / 100);
}
/* RFC 6762 section 5.2 - A random variation of 2% of the record TTL should
* be added to maintenance queries. */
static usec_t mdns_maintenance_jitter(uint32_t ttl) {
return random_u64_range(100) * 2 * ttl * USEC_PER_SEC / 10000;
}
#define MDNS_80_PERCENT 80
#define MDNS_5_PERCENT 5
static void mdns_find_service_from_query(DnsService **service, DnsServiceBrowser *sb, DnsQuery *q) {
assert(sb);
/* Find the service that owns the query. */
LIST_FOREACH(dns_services, s, sb->dns_services) {
if (s->query == q) {
*service = s;
return;
}
}
*service = NULL;
}
static void mdns_maintenance_query_complete(DnsQuery *q) {
_cleanup_(dns_service_browser_unrefp) DnsServiceBrowser *sb = NULL;
_cleanup_(dns_query_freep) DnsQuery *query = q;
DnsService *service = NULL;
int r;
assert(query);
assert(query->manager);
sb = dns_service_browser_ref(hashmap_get(query->manager->dns_service_browsers, query->varlink_request));
if (!sb)
return;
if (query->state != DNS_TRANSACTION_SUCCESS) {
r = 0;
goto finish;
}
r = dns_answer_match_key(query->answer, sb->key, NULL);
if (r <= 0)
goto finish;
r = mdns_browser_lookup_cache(sb, query->answer_family);
finish:
if (r < 0)
log_error_errno(r, "mDNS maintenance query complete failed: %m");
mdns_find_service_from_query(&service, sb, query);
if (service)
service->query = NULL;
}
static int mdns_maintenance_query(sd_event_source *s, uint64_t usec, void *userdata) {
DnsService *service = NULL;
_cleanup_(dns_query_freep) DnsQuery *q = NULL;
int r;
assert(userdata);
service = userdata;
if (service->rr_ttl_state++ == MDNS_TTL_100_PERCENT)
return mdns_browser_lookup_cache(service->sb, service->family);
r = dns_query_new(service->sb->m, &q, service->sb->question_utf8, service->sb->question_idna, NULL, service->sb->ifindex, service->sb->flags);
if (r < 0)
goto finish;
q->complete = mdns_maintenance_query_complete;
q->varlink_request = sd_varlink_ref(service->sb->link);
service->query = TAKE_PTR(q);
usec_t next_time = mdns_maintenance_next_time(service->until, service->rr->ttl, service->rr_ttl_state);
/* Schedule next maintenance query for service */
r = event_reset_time(
service->sb->m->event, &service->schedule_event,
CLOCK_BOOTTIME, next_time, 0, mdns_maintenance_query,
service, 0, "mdns-next-query-schedule", true);
if (r < 0)
goto finish;
r = dns_query_go(service->query);
if (r < 0)
goto finish;
return 0;
finish:
dns_query_free(service->query);
return log_error_errno(r, "Failed mdns maintenance query: %m");
}
int dns_add_new_service(DnsServiceBrowser *sb, DnsResourceRecord *rr, int owner_family) {
_cleanup_(dns_service_unrefp) DnsService *s = NULL;
int r;
assert(sb);
assert(rr);
s = new(DnsService, 1);
if (!s)
return log_oom();
usec_t usec = now(CLOCK_BOOTTIME);
*s = (DnsService) {
.n_ref = 1,
.sb = dns_service_browser_ref(sb),
.rr = dns_resource_record_copy(rr),
.family = owner_family,
.until = rr->until,
.query = NULL,
.rr_ttl_state = MDNS_TTL_80_PERCENT,
};
LIST_PREPEND(dns_services, sb->dns_services, s);
/* Schedule the first cache maintenance query at 80% of the record's TTL.
* Subsequent queries issued at 5% increments until 100% of the TTL. RFC 6762 section 5.2.
* If service is being added after 80% of the TTL has already elapsed,
* schedule the next query at the next 5% increment. */
usec_t next_time = 0;
while (s->rr_ttl_state <= MDNS_TTL_100_PERCENT) {
next_time = mdns_maintenance_next_time(rr->until, rr->ttl, s->rr_ttl_state);
if (next_time >= usec)
break;
s->rr_ttl_state++;
}
if (next_time < usec) {
/* If next_time is still in the past, the service is being added after it has already expired.
* Just schedule a 100% maintenance query */
next_time = usec + USEC_PER_SEC;
s->rr_ttl_state = MDNS_TTL_100_PERCENT;
}
usec_t jitter = mdns_maintenance_jitter(rr->ttl);
r = sd_event_add_time(
sb->m->event,
&s->schedule_event,
CLOCK_BOOTTIME,
usec_add(next_time, jitter),
0,
mdns_maintenance_query,
s);
if (r < 0)
return r;
TAKE_PTR(s);
return 0;
}
void dns_remove_service(DnsServiceBrowser *sb, DnsService *service) {
assert(sb);
assert(service);
LIST_REMOVE(dns_services, sb->dns_services, service);
dns_service_free(service);
}
DnsService *dns_service_free(DnsService *service) {
if (!service)
return NULL;
sd_event_source_disable_unref(service->schedule_event);
if (service->query && DNS_TRANSACTION_IS_LIVE(service->query->state))
dns_query_complete(service->query, DNS_TRANSACTION_ABORTED);
dns_service_browser_unref(service->sb);
dns_resource_record_unref(service->rr);
return mfree(service);
}
DEFINE_TRIVIAL_REF_UNREF_FUNC(DnsService, dns_service, dns_service_free);
int mdns_service_update(DnsService *service, DnsResourceRecord *rr, usec_t t) {
service->until = rr->until;
service->rr->ttl = rr->ttl;
/* Update the 80% TTL maintenance event based on new record received from the network.
* RFC 6762 section 5.2 */
usec_t next_time = mdns_maintenance_next_time(service->until, service->rr->ttl, MDNS_TTL_80_PERCENT);
usec_t jitter = mdns_maintenance_jitter(service->rr->ttl);
if (service->schedule_event)
return sd_event_source_set_time(service->schedule_event, usec_add(next_time, jitter));
return 0;
}
bool dns_service_contains(DnsService *services, DnsResourceRecord *rr, int owner_family) {
usec_t t = now(CLOCK_BOOTTIME);
LIST_FOREACH(dns_services, service, services)
if (dns_resource_record_equal(rr, service->rr) > 0 && service->family == owner_family) {
if (rr->ttl <= 1)
return true;
if (rr->until > service->until)
mdns_service_update(service, rr, t);
return true;
}
return false;
}
void dns_browse_services_purge(Manager *m, int family) {
int r = 0;
/* Called after caches are flused.
* Clear local service records and notify varlink client. */
if (!(m && m->dns_service_browsers))
return;
DnsServiceBrowser *sb;
HASHMAP_FOREACH(sb, m->dns_service_browsers) {
r = sd_event_source_set_enabled(sb->schedule_event, SD_EVENT_OFF);
if (r < 0)
goto finish;
if (family == AF_UNSPEC) {
r = mdns_browser_lookup_cache(sb, AF_INET);
if (r < 0)
goto finish;
r = mdns_browser_lookup_cache(sb, AF_INET6);
if (r < 0)
goto finish;
return;
}
r = mdns_browser_lookup_cache(sb, family);
if (r < 0)
goto finish;
}
finish:
if (r < 0)
log_error_errno(r, "mdns browse services purge failed: %m");
return;
}
int mdns_manage_services_answer(DnsServiceBrowser *sb, DnsAnswer *answer, int owner_family) {
DnsResourceRecord *i;
_cleanup_(sd_json_variant_unrefp) sd_json_variant *array = NULL;
int r;
assert(sb);
/* Check for new service added */
DNS_ANSWER_FOREACH(i, answer) {
_cleanup_free_ char *name = NULL, *type = NULL, *domain = NULL;
_cleanup_(sd_json_variant_unrefp) sd_json_variant *entry = NULL;
if (dns_service_contains(sb->dns_services, i, owner_family))
continue;
r = dns_service_split(i->ptr.name, &name, &type, &domain);
if (r < 0)
goto finish;
if (!name) {
type = mfree(type);
domain = mfree(domain);
r = dns_service_split(dns_resource_key_name(i->key), &name, &type, &domain);
if (r < 0)
goto finish;
}
if (!type)
continue;
r = dns_add_new_service(sb, i, owner_family);
if (r < 0)
goto finish;
log_debug("Add into the list %s, %s, %s, %s, %d",
strna(name),
strna(type),
strna(domain),
strna(af_to_ipv4_ipv6(owner_family)),
sb->ifindex);
r = sd_json_buildo(&entry,
SD_JSON_BUILD_PAIR("add_flag", SD_JSON_BUILD_BOOLEAN(true)),
SD_JSON_BUILD_PAIR("family", SD_JSON_BUILD_INTEGER(owner_family)),
SD_JSON_BUILD_PAIR("name", SD_JSON_BUILD_STRING(name?: "")),
SD_JSON_BUILD_PAIR("type", SD_JSON_BUILD_STRING(type?: "")),
SD_JSON_BUILD_PAIR("domain", SD_JSON_BUILD_STRING(domain?: "")),
SD_JSON_BUILD_PAIR("interface", SD_JSON_BUILD_INTEGER(sb->ifindex)));
if (r < 0)
goto finish;
r = sd_json_variant_append_array(&array, entry);
if (r < 0)
goto finish;
}
/* Check for services removed */
LIST_FOREACH(dns_services, service, sb->dns_services) {
_cleanup_free_ char *name = NULL, *type = NULL, *domain = NULL;
_cleanup_(sd_json_variant_unrefp) sd_json_variant *entry = NULL;
if (service->family != owner_family)
continue;
if (dns_answer_contains(answer, service->rr))
continue;
r = dns_service_split(service->rr->ptr.name, &name, &type, &domain);
if (r < 0)
goto finish;
if (!name) {
type = mfree(type);
domain = mfree(domain);
r = dns_service_split(dns_resource_key_name(service->rr->key), &name, &type, &domain);
if (r < 0)
goto finish;
}
dns_remove_service(sb, service);
log_debug("Remove from the list %s, %s, %s, %s, %d",
strna(name),
strna(type),
strna(domain),
strna(af_to_ipv4_ipv6(owner_family)),
sb->ifindex);
r = sd_json_buildo(&entry,
SD_JSON_BUILD_PAIR("add_flag", SD_JSON_BUILD_BOOLEAN(false)),
SD_JSON_BUILD_PAIR("family", SD_JSON_BUILD_INTEGER(owner_family)),
SD_JSON_BUILD_PAIR("name", SD_JSON_BUILD_STRING(name?: "")),
SD_JSON_BUILD_PAIR("type", SD_JSON_BUILD_STRING(type?: "")),
SD_JSON_BUILD_PAIR("domain", SD_JSON_BUILD_STRING(domain?: "")),
SD_JSON_BUILD_PAIR("interface", SD_JSON_BUILD_INTEGER(sb->ifindex)));
if (r < 0)
goto finish;
r = sd_json_variant_append_array(&array, entry);
if (r < 0)
goto finish;
}
if (!sd_json_variant_is_blank_array(array)) {
_cleanup_(sd_json_variant_unrefp) sd_json_variant *vm = NULL;
r = sd_json_buildo(&vm,
SD_JSON_BUILD_PAIR("browser_service_data", SD_JSON_BUILD_VARIANT(array)));
if (r < 0)
goto finish;
r = sd_varlink_notify(sb->link, vm);
if (r < 0)
goto finish;
}
return 0;
finish:
log_error_errno(r, "Failed to process received services: %m");
return sd_varlink_error_errno(sb->link, r);
}
int mdns_browser_lookup_cache(DnsServiceBrowser *sb, int owner_family) {
_cleanup_(dns_answer_unrefp) DnsAnswer *lookup_ret_answer = NULL;
DnsScope *scope;
int r;
assert(sb);
assert(sb->m);
scope = manager_find_scope_from_protocol(sb->m, sb->ifindex, DNS_PROTOCOL_MDNS, owner_family);
if (!scope)
return 0;
dns_cache_prune(&scope->cache);
r = dns_cache_lookup(
&scope->cache,
sb->key,
sb->flags,
NULL,
&lookup_ret_answer,
NULL,
NULL,
NULL);
if (r < 0)
return r;
return mdns_manage_services_answer(sb, lookup_ret_answer, owner_family);
}
int mdns_notify_browsers_goodbye(DnsScope *scope) {
DnsServiceBrowser *sb = NULL;
int r;
if (!scope)
return 0;
HASHMAP_FOREACH(sb, scope->manager->dns_service_browsers) {
r = mdns_browser_lookup_cache(sb, scope->family);
if (r < 0)
goto finish;
}
return 0;
finish:
return r;
}
int mdns_notify_browsers_unsolicited_updates(Manager *m, DnsAnswer *answer, int owner_family) {
DnsServiceBrowser *sb = NULL;
int r;
assert(m);
if (!answer)
return 0;
if (!m->dns_service_browsers)
return 0;
HASHMAP_FOREACH(sb, m->dns_service_browsers) {
r = dns_answer_match_key(answer, sb->key, NULL);
if (r < 0)
goto finish;
else if (r == 0)
continue;
r = mdns_browser_lookup_cache(sb, owner_family);
if (r < 0)
goto finish;
}
return 0;
finish:
return log_error_errno(r, "Failed to notify mDNS service subscribers, %m");
}
static void mdns_browse_service_query_complete(DnsQuery *q) {
_cleanup_(dns_service_browser_unrefp) DnsServiceBrowser *sb = NULL;
_cleanup_(dns_query_freep) DnsQuery *query = q;
int r;
assert(query);
assert(query->manager);
if (query->state != DNS_TRANSACTION_SUCCESS)
return;
sb = dns_service_browser_ref(hashmap_get(query->manager->dns_service_browsers, query->varlink_request));
if (!sb)
return;
r = dns_answer_match_key(query->answer, sb->key, NULL);
if (r < 0)
goto finish;
else if (r == 0)
return;
r = mdns_browser_lookup_cache(sb, query->answer_family);
if (r < 0)
goto finish;
/* When the query is answered from cache, we only get answers for one answer_family
* i.e. either ipv4 or ipv6.
* We need to perform another cache lookup for the other answer_family */
if (query->answer_query_flags == SD_RESOLVED_FROM_CACHE) {
r = mdns_browser_lookup_cache(sb, query->answer_family == AF_INET? AF_INET6 : AF_INET);
if (r < 0)
goto finish;
}
return;
finish:
log_error_errno(r, "mDNS browse query complete failed, %m");
}
static int mdns_next_query_schedule(sd_event_source *s, uint64_t usec, void *userdata) {
_cleanup_(dns_service_browser_unrefp) DnsServiceBrowser *sb = NULL;
_cleanup_(dns_query_freep) DnsQuery *q = NULL;
int r;
assert(userdata);
sb = dns_service_browser_ref(userdata);
r = dns_query_new(sb->m, &q, sb->question_utf8, sb->question_idna, NULL, sb->ifindex, sb->flags);
if (r < 0)
goto finish;
q->complete = mdns_browse_service_query_complete;
q->varlink_request = sd_varlink_ref(sb->link);
sd_varlink_set_userdata(sb->link, q);
r = dns_query_go(q);
if (r < 0)
goto finish;
/* RFC6762 5.2
* The intervals between successive queries MUST increase by at least a factor of two.
* When the interval between queries reaches or exceeds 60 minutes,perform
* subsequent queries at a steady-state rate of one query per hour */
if (sb->delay == 0) {
sb->delay++;
/* First query is sent wihtout SD_RESOLVED_NO_CACHE to fetch answers already in cache.
* Set SD_RESOLVED_NO_CACHE to make all subsequent queries go to the network. */
sb->flags |= SD_RESOLVED_NO_CACHE;
}
else
sb->delay = sb->delay < 2048 ? sb->delay * 2 : 3600;
r = event_reset_time_relative(
sb->m->event, &sb->schedule_event,
CLOCK_BOOTTIME, (sb->delay * USEC_PER_SEC),
0, mdns_next_query_schedule,
sb, 0, "mdns-next-query-schedule", true);
if (r < 0)
goto finish;
TAKE_PTR(q);
return 0;
finish:
return log_error_errno(r, "Failed to schedule mDNS query, %m");
}
void dns_service_browser_reset(Manager *m) {
int r;
if (!(m && m->dns_service_browsers))
return;
DnsServiceBrowser *sb;
HASHMAP_FOREACH(sb, m->dns_service_browsers) {
sb->delay = 0;
r = event_reset_time_relative(
sb->m->event, &sb->schedule_event,
CLOCK_BOOTTIME, (sb->delay * USEC_PER_SEC),
0, mdns_next_query_schedule,
sb, 0, "mdns-next-query-schedule", true);
if (r < 0)
log_error_errno(r, "Failed to reset mdns service subscriber, %m");
}
return;
}
int dns_subscribe_browse_service(
Manager *m,
sd_varlink *link,
const char *domain,
const char *name,
const char *type,
int ifindex,
uint64_t flags) {
_cleanup_(dns_service_browser_unrefp) DnsServiceBrowser *sb = NULL;
_cleanup_(dns_question_unrefp) DnsQuestion *question_idna = NULL, *question_utf8 = NULL;
int r;
assert(m);
assert(link);
if (ifindex <= 0)
return sd_varlink_error_invalid_parameter(link, JSON_VARIANT_STRING_CONST("ifindex"));
if (isempty(name))
name = NULL;
else if (!dns_service_name_is_valid(name))
return sd_varlink_error_invalid_parameter(link, JSON_VARIANT_STRING_CONST("name"));
if (isempty(type))
type = NULL;
else if (!dnssd_srv_type_is_valid(type))
return sd_varlink_error_invalid_parameter(link, JSON_VARIANT_STRING_CONST("type"));
r = dns_name_is_valid(domain);
if (r < 0)
return r;
if (r == 0)
return sd_varlink_error_invalid_parameter(link, JSON_VARIANT_STRING_CONST("domain"));
r = dns_question_new_service_type(&question_utf8, name, type, domain, false, DNS_TYPE_PTR);
if (r < 0)
return r;
r = dns_question_new_service_type(&question_idna, name, type, domain, true, DNS_TYPE_PTR);
if (r < 0)
return r;
sb = new(DnsServiceBrowser, 1);
if (!sb)
return log_oom();
*sb = (DnsServiceBrowser) {
.n_ref = 1,
.m = m,
.link = sd_varlink_ref(link),
.question_utf8 = dns_question_ref(question_utf8),
.question_idna = dns_question_ref(question_idna),
.key = dns_question_first_key(question_utf8),
.ifindex = ifindex,
.flags = flags,
};
/* Only mDNS continuous querying is currently supported. See RFC 6762 */
switch (flags & SD_RESOLVED_PROTOCOLS_ALL) {
case SD_RESOLVED_MDNS:
r = sd_event_add_time(m->event,
&sb->schedule_event,
CLOCK_BOOTTIME,
usec_add(now(CLOCK_BOOTTIME), (sb->delay * USEC_PER_SEC)),
0,
mdns_next_query_schedule,
sb);
if (r < 0)
return r;
break;
default:
return -EINVAL;
}
r = hashmap_ensure_put(&m->dns_service_browsers, NULL, link, sb);
if (r < 0)
return r;
TAKE_PTR(sb);
return 0;
}
DnsServiceBrowser *dns_service_browser_free(DnsServiceBrowser *sb) {
DnsQuery *q;
if (!sb)
return NULL;
LIST_FOREACH(dns_services, service, sb->dns_services)
dns_remove_service(sb, service);
sd_event_source_disable_unref(sb->schedule_event);
q = sd_varlink_get_userdata(sb->link);
if (q && DNS_TRANSACTION_IS_LIVE(q->state))
dns_query_complete(q, DNS_TRANSACTION_ABORTED);
dns_question_unref(sb->question_idna);
dns_question_unref(sb->question_utf8);
sd_varlink_unref(sb->link);
return mfree(sb);
}
DEFINE_TRIVIAL_REF_UNREF_FUNC(DnsServiceBrowser, dns_service_browser, dns_service_browser_free);

View File

@ -0,0 +1,79 @@
/* SPDX-License-Identifier: LGPL-2.1-or-later */
#pragma once
typedef struct DnsServiceBrowser DnsServiceBrowser;
#include "resolved-dns-query.h"
#include "resolved-manager.h"
#include "sd-varlink.h"
typedef struct DnsService DnsService;
typedef enum DnsRecordTTLState DnsRecordTTLState;
enum DnsRecordTTLState {
MDNS_TTL_80_PERCENT,
MDNS_TTL_85_PERCENT,
MDNS_TTL_90_PERCENT,
MDNS_TTL_95_PERCENT,
MDNS_TTL_100_PERCENT
};
struct DnsService {
unsigned n_ref;
DnsServiceBrowser *sb;
sd_event_source *schedule_event;
DnsResourceRecord *rr;
int family;
usec_t until;
DnsRecordTTLState rr_ttl_state;
DnsQuery *query;
LIST_FIELDS(DnsService, dns_services);
};
struct DnsServiceBrowser {
unsigned n_ref;
Manager *m;
sd_varlink *link;
DnsQuestion *question_idna;
DnsQuestion *question_utf8;
uint64_t flags;
sd_event_source *schedule_event;
usec_t delay;
DnsResourceKey *key;
int ifindex;
uint64_t token;
LIST_HEAD(DnsService, dns_services);
};
DnsServiceBrowser *dns_service_browser_free(DnsServiceBrowser *sb);
void dns_remove_service(DnsServiceBrowser *sb, DnsService *service);
DnsService *dns_service_free(DnsService *service);
DnsServiceBrowser* dns_service_browser_ref(DnsServiceBrowser *sb);
DnsServiceBrowser* dns_service_browser_unref(DnsServiceBrowser *sb);
DnsService* dns_service_ref(DnsService *service);
DnsService* dns_service_unref(DnsService *service);
void dns_browse_services_purge(Manager *m, int family);
void dns_service_browser_reset(Manager *m);
DEFINE_TRIVIAL_CLEANUP_FUNC(DnsServiceBrowser*, dns_service_browser_unref);
DEFINE_TRIVIAL_CLEANUP_FUNC(DnsService*, dns_service_unref);
bool dns_service_contains(DnsService *services, DnsResourceRecord *rr, int owner_family);
int mdns_manage_services_answer(DnsServiceBrowser *sb, DnsAnswer *answer, int owner_family);
int dns_add_new_service(DnsServiceBrowser *sb, DnsResourceRecord *rr, int owner_family);
int mdns_service_update(DnsService *service, DnsResourceRecord *rr, usec_t t);
int mdns_browser_lookup_cache(DnsServiceBrowser *sb, int owner_family);
int dns_subscribe_browse_service(Manager *m,
sd_varlink *link,
const char *domain,
const char * name,
const char * type,
int ifindex,
uint64_t flags);
int mdns_notify_browsers_unsolicited_updates(Manager *m, DnsAnswer *answer, int owner_family);
int mdns_notify_browsers_goodbye(DnsScope *scope);

View File

@ -1011,6 +1011,7 @@ static int answer_add_clamp_ttl(
} }
} }
rr->until = until;
r = dns_answer_add_extend(answer, rr, ifindex, answer_flags, rrsig); r = dns_answer_add_extend(answer, rr, ifindex, answer_flags, rrsig);
if (r < 0) if (r < 0)
return r; return r;

View File

@ -416,6 +416,66 @@ int dns_question_new_reverse(DnsQuestion **ret, int family, const union in_addr_
return 0; return 0;
} }
int dns_question_new_service_type(
DnsQuestion **ret,
const char *service,
const char *type,
const char *domain,
bool convert_idna,
uint16_t record_type) {
_cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL;
_cleanup_(dns_question_unrefp) DnsQuestion *q = NULL;
_cleanup_free_ char *buf = NULL, *joined = NULL;
const char *name;
int r;
assert(ret);
if (record_type == DNS_TYPE_SRV)
return -EINVAL;
if (!domain)
return -EINVAL;
if (type) {
if (convert_idna) {
r = dns_name_apply_idna(domain, &buf);
if (r < 0)
return r;
if (r > 0)
domain = buf;
}
r = dns_service_join(service, type, domain, &joined);
if (r < 0)
return r;
name = joined;
} else {
if (service)
return -EINVAL;
name = domain;
}
q = dns_question_new(1);
if (!q)
return -ENOMEM;
key = dns_resource_key_new(DNS_CLASS_IN, record_type, name);
if (!key)
return -ENOMEM;
r = dns_question_add(q, key, 0);
if (r < 0)
return r;
*ret = TAKE_PTR(q);
return 0;
}
int dns_question_new_service( int dns_question_new_service(
DnsQuestion **ret, DnsQuestion **ret,
const char *service, const char *service,

View File

@ -31,6 +31,7 @@ DnsQuestion *dns_question_unref(DnsQuestion *q);
int dns_question_new_address(DnsQuestion **ret, int family, const char *name, bool convert_idna); int dns_question_new_address(DnsQuestion **ret, int family, const char *name, bool convert_idna);
int dns_question_new_reverse(DnsQuestion **ret, int family, const union in_addr_union *a); int dns_question_new_reverse(DnsQuestion **ret, int family, const union in_addr_union *a);
int dns_question_new_service(DnsQuestion **ret, const char *service, const char *type, const char *domain, bool with_txt, bool convert_idna); int dns_question_new_service(DnsQuestion **ret, const char *service, const char *type, const char *domain, bool with_txt, bool convert_idna);
int dns_question_new_service_type(DnsQuestion **ret, const char *service, const char *type, const char *domain, bool convert_idna, uint16_t record_type);
int dns_question_add_raw(DnsQuestion *q, DnsResourceKey *key, DnsQuestionFlags flags); int dns_question_add_raw(DnsQuestion *q, DnsResourceKey *key, DnsQuestionFlags flags);
int dns_question_add(DnsQuestion *q, DnsResourceKey *key, DnsQuestionFlags flags); int dns_question_add(DnsQuestion *q, DnsResourceKey *key, DnsQuestionFlags flags);

View File

@ -398,6 +398,7 @@ DnsResourceRecord* dns_resource_record_new(DnsResourceKey *key) {
.n_ref = 1, .n_ref = 1,
.key = dns_resource_key_ref(key), .key = dns_resource_key_ref(key),
.expiry = USEC_INFINITY, .expiry = USEC_INFINITY,
.until = USEC_INFINITY,
.n_skip_labels_signer = UINT8_MAX, .n_skip_labels_signer = UINT8_MAX,
.n_skip_labels_source = UINT8_MAX, .n_skip_labels_source = UINT8_MAX,
}; };
@ -1704,6 +1705,7 @@ DnsResourceRecord *dns_resource_record_copy(DnsResourceRecord *rr) {
copy->ttl = rr->ttl; copy->ttl = rr->ttl;
copy->expiry = rr->expiry; copy->expiry = rr->expiry;
copy->until = rr->until;
copy->n_skip_labels_signer = rr->n_skip_labels_signer; copy->n_skip_labels_signer = rr->n_skip_labels_signer;
copy->n_skip_labels_source = rr->n_skip_labels_source; copy->n_skip_labels_source = rr->n_skip_labels_source;
copy->unparsable = rr->unparsable; copy->unparsable = rr->unparsable;

View File

@ -107,6 +107,8 @@ struct DnsResourceRecord {
unsigned n_ref; unsigned n_ref;
uint32_t ttl; uint32_t ttl;
usec_t expiry; /* RRSIG signature expiry */ usec_t expiry; /* RRSIG signature expiry */
usec_t until; /* Used to pass until of a record when doing a dns_cache_lookup().
* Needed to schedule cache maintenance queries when browsing for services. */
DnsResourceKey *key; DnsResourceKey *key;

View File

@ -10,6 +10,7 @@
#include "hostname-util.h" #include "hostname-util.h"
#include "missing_network.h" #include "missing_network.h"
#include "random-util.h" #include "random-util.h"
#include "resolved-dns-browse-services.h"
#include "resolved-dnssd.h" #include "resolved-dnssd.h"
#include "resolved-dns-scope.h" #include "resolved-dns-scope.h"
#include "resolved-dns-synthesize.h" #include "resolved-dns-synthesize.h"
@ -121,6 +122,9 @@ DnsScope* dns_scope_free(DnsScope *s) {
dns_cache_flush(&s->cache); dns_cache_flush(&s->cache);
dns_zone_flush(&s->zone); dns_zone_flush(&s->zone);
/* Clear records of mDNS service browse subscriber, since cache bas been flushed */
dns_browse_services_purge(s->manager, s->family);
LIST_REMOVE(scopes, s->manager->dns_scopes, s); LIST_REMOVE(scopes, s->manager->dns_scopes, s);
return mfree(s); return mfree(s);
} }

View File

@ -14,6 +14,7 @@
#include "mkdir.h" #include "mkdir.h"
#include "netif-util.h" #include "netif-util.h"
#include "parse-util.h" #include "parse-util.h"
#include "resolved-dns-browse-services.h"
#include "resolved-link.h" #include "resolved-link.h"
#include "resolved-llmnr.h" #include "resolved-llmnr.h"
#include "resolved-mdns.h" #include "resolved-mdns.h"
@ -166,6 +167,7 @@ void link_allocate_scopes(Link *l) {
r = dns_scope_new(l->manager, &l->mdns_ipv4_scope, l, DNS_PROTOCOL_MDNS, AF_INET); r = dns_scope_new(l->manager, &l->mdns_ipv4_scope, l, DNS_PROTOCOL_MDNS, AF_INET);
if (r < 0) if (r < 0)
log_link_warning_errno(l, r, "Failed to allocate mDNS IPv4 scope, ignoring: %m"); log_link_warning_errno(l, r, "Failed to allocate mDNS IPv4 scope, ignoring: %m");
dns_service_browser_reset(l->manager);
} }
} else } else
l->mdns_ipv4_scope = dns_scope_free(l->mdns_ipv4_scope); l->mdns_ipv4_scope = dns_scope_free(l->mdns_ipv4_scope);
@ -176,6 +178,7 @@ void link_allocate_scopes(Link *l) {
r = dns_scope_new(l->manager, &l->mdns_ipv6_scope, l, DNS_PROTOCOL_MDNS, AF_INET6); r = dns_scope_new(l->manager, &l->mdns_ipv6_scope, l, DNS_PROTOCOL_MDNS, AF_INET6);
if (r < 0) if (r < 0)
log_link_warning_errno(l, r, "Failed to allocate mDNS IPv6 scope, ignoring: %m"); log_link_warning_errno(l, r, "Failed to allocate mDNS IPv6 scope, ignoring: %m");
dns_service_browser_reset(l->manager);
} }
} else } else
l->mdns_ipv6_scope = dns_scope_free(l->mdns_ipv6_scope); l->mdns_ipv6_scope = dns_scope_free(l->mdns_ipv6_scope);

View File

@ -769,6 +769,7 @@ int manager_start(Manager *m) {
Manager *manager_free(Manager *m) { Manager *manager_free(Manager *m) {
Link *l; Link *l;
DnssdService *s; DnssdService *s;
DnsServiceBrowser *sb;
if (!m) if (!m)
return NULL; return NULL;
@ -840,6 +841,10 @@ Manager *manager_free(Manager *m) {
dns_trust_anchor_flush(&m->trust_anchor); dns_trust_anchor_flush(&m->trust_anchor);
manager_etc_hosts_flush(m); manager_etc_hosts_flush(m);
while ((sb = hashmap_first(m->dns_service_browsers)))
dns_service_browser_free(sb);
hashmap_free(m->dns_service_browsers);
return mfree(m); return mfree(m);
} }
@ -1474,29 +1479,28 @@ bool manager_packet_from_our_transaction(Manager *m, DnsPacket *p) {
return t->sent && dns_packet_equal(t->sent, p); return t->sent && dns_packet_equal(t->sent, p);
} }
DnsScope* manager_find_scope(Manager *m, DnsPacket *p) { DnsScope* manager_find_scope_from_protocol(Manager *m, int ifindex, DnsProtocol protocol, int family) {
Link *l; Link *l;
assert(m); assert(m);
assert(p);
l = hashmap_get(m->links, INT_TO_PTR(p->ifindex)); l = hashmap_get(m->links, INT_TO_PTR(ifindex));
if (!l) if (!l)
return NULL; return NULL;
switch (p->protocol) { switch (protocol) {
case DNS_PROTOCOL_LLMNR: case DNS_PROTOCOL_LLMNR:
if (p->family == AF_INET) if (family == AF_INET)
return l->llmnr_ipv4_scope; return l->llmnr_ipv4_scope;
else if (p->family == AF_INET6) else if (family == AF_INET6)
return l->llmnr_ipv6_scope; return l->llmnr_ipv6_scope;
break; break;
case DNS_PROTOCOL_MDNS: case DNS_PROTOCOL_MDNS:
if (p->family == AF_INET) if (family == AF_INET)
return l->mdns_ipv4_scope; return l->mdns_ipv4_scope;
else if (p->family == AF_INET6) else if (family == AF_INET6)
return l->mdns_ipv6_scope; return l->mdns_ipv6_scope;
break; break;
@ -1706,6 +1710,9 @@ void manager_flush_caches(Manager *m, int log_level) {
LIST_FOREACH(scopes, scope, m->dns_scopes) LIST_FOREACH(scopes, scope, m->dns_scopes)
dns_cache_flush(&scope->cache); dns_cache_flush(&scope->cache);
dns_browse_services_purge(m, AF_UNSPEC); /* Clear records of DNS service browse subscriber, since caches are flushed */
dns_service_browser_reset(m);
log_full(log_level, "Flushed all caches."); log_full(log_level, "Flushed all caches.");
} }

View File

@ -16,6 +16,7 @@
typedef struct Manager Manager; typedef struct Manager Manager;
#include "resolved-dns-browse-services.h"
#include "resolved-dns-query.h" #include "resolved-dns-query.h"
#include "resolved-dns-search-domain.h" #include "resolved-dns-search-domain.h"
#include "resolved-dns-stream.h" #include "resolved-dns-stream.h"
@ -161,6 +162,9 @@ struct Manager {
size_t n_socket_graveyard; size_t n_socket_graveyard;
struct sigrtmin18_info sigrtmin18_info; struct sigrtmin18_info sigrtmin18_info;
/* Map varlink links to DnsServiceBrowser instances. */
Hashmap *dns_service_browsers;
}; };
/* Manager */ /* Manager */
@ -188,7 +192,13 @@ int manager_next_hostname(Manager *m);
bool manager_packet_from_local_address(Manager *m, DnsPacket *p); bool manager_packet_from_local_address(Manager *m, DnsPacket *p);
bool manager_packet_from_our_transaction(Manager *m, DnsPacket *p); bool manager_packet_from_our_transaction(Manager *m, DnsPacket *p);
DnsScope* manager_find_scope(Manager *m, DnsPacket *p); DnsScope* manager_find_scope_from_protocol(Manager *m, int ifindex, DnsProtocol protocol, int family);
static inline DnsScope* manager_find_scope(Manager *m, DnsPacket *p) {
assert(m);
assert(p);
return manager_find_scope_from_protocol(m, p->ifindex, p->protocol, p->family);
}
void manager_verify_all(Manager *m); void manager_verify_all(Manager *m);

View File

@ -359,6 +359,10 @@ static int mdns_goodbye_callback(sd_event_source *s, uint64_t usec, void *userda
dns_cache_prune(&scope->cache); dns_cache_prune(&scope->cache);
r = mdns_notify_browsers_goodbye(scope);
if (r < 0)
log_error_errno(r, "mDNS: Failed to notify service subscribers of goodbyes, %m");
if (dns_cache_expiry_in_one_second(&scope->cache, usec)) { if (dns_cache_expiry_in_one_second(&scope->cache, usec)) {
r = sd_event_add_time_relative( r = sd_event_add_time_relative(
scope->manager->event, scope->manager->event,
@ -380,6 +384,7 @@ static int on_mdns_packet(sd_event_source *s, int fd, uint32_t revents, void *us
Manager *m = userdata; Manager *m = userdata;
DnsScope *scope; DnsScope *scope;
int r; int r;
bool unsolicited_packet = true;
r = manager_recv(m, fd, DNS_PROTOCOL_MDNS, &p); r = manager_recv(m, fd, DNS_PROTOCOL_MDNS, &p);
if (r <= 0) if (r <= 0)
@ -455,30 +460,6 @@ static int on_mdns_packet(sd_event_source *s, int fd, uint32_t revents, void *us
} }
} }
for (bool match = true; match;) {
match = false;
LIST_FOREACH(transactions_by_scope, t, scope->transactions) {
if (t->state != DNS_TRANSACTION_PENDING)
continue;
r = dns_answer_match_key(p->answer, dns_transaction_key(t), NULL);
if (r <= 0) {
if (r < 0)
log_debug_errno(r, "Failed to match resource key, ignoring: %m");
continue;
}
/* This packet matches the transaction, let's pass it on as reply */
dns_transaction_process_reply(t, p, false);
/* The dns_transaction_process_reply() -> dns_transaction_complete() ->
* dns_query_candidate_stop() may free multiple transactions. Hence, restart
* the loop. */
match = true;
break;
}
}
dns_cache_put( dns_cache_put(
&scope->cache, &scope->cache,
scope->manager->enable_cache, scope->manager->enable_cache,
@ -494,6 +475,35 @@ static int on_mdns_packet(sd_event_source *s, int fd, uint32_t revents, void *us
&p->sender, &p->sender,
scope->manager->stale_retention_usec); scope->manager->stale_retention_usec);
for (bool match = true; match;) {
match = false;
LIST_FOREACH(transactions_by_scope, t, scope->transactions) {
if (t->state != DNS_TRANSACTION_PENDING)
continue;
r = dns_answer_match_key(p->answer, dns_transaction_key(t), NULL);
if (r <= 0) {
if (r < 0)
log_debug_errno(r, "Failed to match resource key, ignoring: %m");
continue;
}
unsolicited_packet = false;
/* This packet matches the transaction, let's pass it on as reply */
dns_transaction_process_reply(t, p, false);
/* The dns_transaction_process_reply() -> dns_transaction_complete() ->
* dns_query_candidate_stop() may free multiple transactions. Hence, restart
* the loop. */
match = true;
break;
}
}
/* Check incoming packet key matches with active clients if yes update the same */
if (unsolicited_packet)
mdns_notify_browsers_unsolicited_updates(m, p->answer, p->family);
} else if (dns_packet_validate_query(p) > 0) { } else if (dns_packet_validate_query(p) > 0) {
log_debug("Got mDNS query packet for id %u", DNS_PACKET_ID(p)); log_debug("Got mDNS query packet for id %u", DNS_PACKET_ID(p));

View File

@ -4,6 +4,7 @@
#include "glyph-util.h" #include "glyph-util.h"
#include "in-addr-util.h" #include "in-addr-util.h"
#include "json-util.h" #include "json-util.h"
#include "resolved-dns-browse-services.h"
#include "resolved-dns-synthesize.h" #include "resolved-dns-synthesize.h"
#include "resolved-varlink.h" #include "resolved-varlink.h"
#include "socket-netlink.h" #include "socket-netlink.h"
@ -30,11 +31,26 @@ typedef struct LookupParametersResolveService {
uint64_t flags; uint64_t flags;
} LookupParametersResolveService; } LookupParametersResolveService;
typedef struct LookupParametersMdnsBrowse {
char *domainName;
char *name;
char *type;
int ifindex;
uint64_t flags;
} LookupParametersMdnsBrowse;
static void lookup_parameters_destroy(LookupParameters *p) { static void lookup_parameters_destroy(LookupParameters *p) {
assert(p); assert(p);
free(p->name); free(p->name);
} }
static void lookup_parameters_mdns_destroy(LookupParametersMdnsBrowse *p) {
assert(p);
free(p->domainName);
free(p->name);
free(p->type);
}
static int reply_query_state(DnsQuery *q) { static int reply_query_state(DnsQuery *q) {
assert(q); assert(q);
@ -108,10 +124,18 @@ static int reply_query_state(DnsQuery *q) {
static void vl_on_disconnect(sd_varlink_server *s, sd_varlink *link, void *userdata) { static void vl_on_disconnect(sd_varlink_server *s, sd_varlink *link, void *userdata) {
DnsQuery *q; DnsQuery *q;
Manager *m;
assert(s); assert(s);
assert(link); assert(link);
m = sd_varlink_server_get_userdata(s);
if (!m)
return;
DnsServiceBrowser *sb = hashmap_remove(m->dns_service_browsers, link);
dns_service_browser_free(sb);
q = sd_varlink_get_userdata(link); q = sd_varlink_get_userdata(link);
if (!q) if (!q)
return; return;
@ -1209,6 +1233,43 @@ static int verify_polkit(sd_varlink *link, sd_json_variant *parameters, const ch
&m->polkit_registry); &m->polkit_registry);
} }
static int vl_method_start_browse(sd_varlink* link, sd_json_variant* parameters, sd_varlink_method_flags_t flags, void* userdata) {
static const sd_json_dispatch_field dispatch_table[] = {
{ "domainName", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(LookupParametersMdnsBrowse, domainName), SD_JSON_MANDATORY },
{ "name", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(LookupParametersMdnsBrowse, name), 0 },
{ "type", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(LookupParametersMdnsBrowse, type), 0 },
{ "ifindex", _SD_JSON_VARIANT_TYPE_INVALID, sd_json_dispatch_int, offsetof(LookupParametersMdnsBrowse, ifindex), SD_JSON_MANDATORY },
{ "flags", _SD_JSON_VARIANT_TYPE_INVALID, sd_json_dispatch_uint64, offsetof(LookupParametersMdnsBrowse, flags), SD_JSON_MANDATORY },
{}
};
_cleanup_(lookup_parameters_mdns_destroy) LookupParametersMdnsBrowse p = {};
Manager *m;
int r = 0;
assert(link);
/* if the client didn't set the more flag, it is using us incorrectly */
if (!FLAGS_SET(flags, SD_VARLINK_METHOD_MORE))
return sd_varlink_error(link, SD_VARLINK_ERROR_EXPECTED_MORE, NULL);
m = sd_varlink_server_get_userdata(sd_varlink_get_server(link));
assert(m);
r = sd_varlink_dispatch(link, parameters, dispatch_table, &p);
if (r < 0)
return log_error_errno(r, "vl_method_start_browse json_dispatch fail: %m");
if (!validate_and_mangle_flags(NULL, &p.flags, 0))
return sd_varlink_error_invalid_parameter(link, JSON_VARIANT_STRING_CONST("flags"));
r = dns_subscribe_browse_service(m, link, p.domainName, p.name, p.type, p.ifindex, p.flags);
if (r < 0)
return sd_varlink_error_errno(link, r);
return 1;
}
static int vl_method_subscribe_query_results(sd_varlink *link, sd_json_variant *parameters, sd_varlink_method_flags_t flags, void *userdata) { static int vl_method_subscribe_query_results(sd_varlink *link, sd_json_variant *parameters, sd_varlink_method_flags_t flags, void *userdata) {
Manager *m = ASSERT_PTR(sd_varlink_get_userdata(ASSERT_PTR(link))); Manager *m = ASSERT_PTR(sd_varlink_get_userdata(ASSERT_PTR(link)));
int r; int r;
@ -1422,7 +1483,8 @@ static int varlink_main_server_init(Manager *m) {
"io.systemd.Resolve.ResolveHostname", vl_method_resolve_hostname, "io.systemd.Resolve.ResolveHostname", vl_method_resolve_hostname,
"io.systemd.Resolve.ResolveAddress", vl_method_resolve_address, "io.systemd.Resolve.ResolveAddress", vl_method_resolve_address,
"io.systemd.Resolve.ResolveService", vl_method_resolve_service, "io.systemd.Resolve.ResolveService", vl_method_resolve_service,
"io.systemd.Resolve.ResolveRecord", vl_method_resolve_record); "io.systemd.Resolve.ResolveRecord", vl_method_resolve_record,
"io.systemd.Resolve.StartBrowse", vl_method_start_browse);
if (r < 0) if (r < 0)
return log_error_errno(r, "Failed to register varlink methods: %m"); return log_error_errno(r, "Failed to register varlink methods: %m");

View File

@ -1808,63 +1808,81 @@ char* umount_and_unlink_and_free(char *p) {
return mfree(p); return mfree(p);
} }
static int path_get_mount_info( static int path_get_mount_info_at(
int dir_fd,
const char *path, const char *path,
char **ret_fstype, char **ret_fstype,
char **ret_options) { char **ret_options) {
_cleanup_(mnt_free_tablep) struct libmnt_table *table = NULL; _cleanup_(mnt_free_tablep) struct libmnt_table *table = NULL;
_cleanup_free_ char *fstype = NULL, *options = NULL; _cleanup_(mnt_free_iterp) struct libmnt_iter *iter = NULL;
struct libmnt_fs *fs; int r, mnt_id;
int r;
assert(path); assert(dir_fd >= 0 || dir_fd == AT_FDCWD);
table = mnt_new_table(); r = path_get_mnt_id_at(dir_fd, path, &mnt_id);
if (!table)
return -ENOMEM;
r = mnt_table_parse_mtab(table, /* filename = */ NULL);
if (r < 0) if (r < 0)
return r; return log_debug_errno(r, "Failed to get mount ID: %m");
fs = mnt_table_find_mountpoint(table, path, MNT_ITER_FORWARD); r = libmount_parse("/proc/self/mountinfo", NULL, &table, &iter);
if (!fs) if (r < 0)
return -EINVAL; return log_debug_errno(r, "Failed to parse /proc/self/mountinfo: %m");
if (ret_fstype) { for (;;) {
fstype = strdup(strempty(mnt_fs_get_fstype(fs))); struct libmnt_fs *fs;
if (!fstype)
return -ENOMEM; r = mnt_table_next_fs(table, iter, &fs);
if (r == 1)
break; /* EOF */
if (r < 0)
return log_debug_errno(r, "Failed to get next entry from /proc/self/mountinfo: %m");
if (mnt_fs_get_id(fs) != mnt_id)
continue;
_cleanup_free_ char *fstype = NULL, *options = NULL;
if (ret_fstype) {
fstype = strdup(strempty(mnt_fs_get_fstype(fs)));
if (!fstype)
return log_oom_debug();
}
if (ret_options) {
options = strdup(strempty(mnt_fs_get_options(fs)));
if (!options)
return log_oom_debug();
}
if (ret_fstype)
*ret_fstype = TAKE_PTR(fstype);
if (ret_options)
*ret_options = TAKE_PTR(options);
return 0;
} }
if (ret_options) { return log_debug_errno(SYNTHETIC_ERRNO(ESTALE), "Cannot find mount ID %i from /proc/self/mountinfo.", mnt_id);
options = strdup(strempty(mnt_fs_get_options(fs)));
if (!options)
return -ENOMEM;
}
if (ret_fstype)
*ret_fstype = TAKE_PTR(fstype);
if (ret_options)
*ret_options = TAKE_PTR(options);
return 0;
} }
int path_is_network_fs_harder(const char *path) { int path_is_network_fs_harder_at(int dir_fd, const char *path) {
_cleanup_close_ int fd = -EBADF;
int r;
assert(dir_fd >= 0 || dir_fd == AT_FDCWD);
fd = xopenat(dir_fd, path, O_PATH | O_CLOEXEC | O_NOFOLLOW);
if (fd < 0)
return fd;
r = fd_is_network_fs(fd);
if (r != 0)
return r;
_cleanup_free_ char *fstype = NULL, *options = NULL; _cleanup_free_ char *fstype = NULL, *options = NULL;
int r, ret; r = path_get_mount_info_at(fd, /* path = */ NULL, &fstype, &options);
assert(path);
ret = path_is_network_fs(path);
if (ret > 0)
return true;
r = path_get_mount_info(path, &fstype, &options);
if (r < 0) if (r < 0)
return RET_GATHER(ret, r); return r;
if (fstype_is_network(fstype)) if (fstype_is_network(fstype))
return true; return true;

View File

@ -181,4 +181,7 @@ int mount_credentials_fs(const char *path, size_t size, bool ro);
int make_fsmount(int error_log_level, const char *what, const char *type, unsigned long flags, const char *options, int userns_fd); int make_fsmount(int error_log_level, const char *what, const char *type, unsigned long flags, const char *options, int userns_fd);
int path_is_network_fs_harder(const char *path); int path_is_network_fs_harder_at(int dir_fd, const char *path);
static inline int path_is_network_fs_harder(const char *path) {
return path_is_network_fs_harder_at(AT_FDCWD, path);
}

View File

@ -102,6 +102,15 @@ static SD_VARLINK_DEFINE_STRUCT_TYPE(
SD_VARLINK_DEFINE_FIELD(ifindex, SD_VARLINK_INT, SD_VARLINK_NULLABLE), SD_VARLINK_DEFINE_FIELD(ifindex, SD_VARLINK_INT, SD_VARLINK_NULLABLE),
SD_VARLINK_DEFINE_FIELD(name, SD_VARLINK_STRING, 0)); SD_VARLINK_DEFINE_FIELD(name, SD_VARLINK_STRING, 0));
static SD_VARLINK_DEFINE_STRUCT_TYPE(
ServiceData,
SD_VARLINK_DEFINE_FIELD(add_flag, SD_VARLINK_BOOL, 0),
SD_VARLINK_DEFINE_FIELD(family, SD_VARLINK_INT, 0),
SD_VARLINK_DEFINE_FIELD(name, SD_VARLINK_STRING, SD_VARLINK_NULLABLE),
SD_VARLINK_DEFINE_FIELD(type, SD_VARLINK_STRING, 0),
SD_VARLINK_DEFINE_FIELD(domain, SD_VARLINK_STRING, 0),
SD_VARLINK_DEFINE_FIELD(interface, SD_VARLINK_INT, 0));
static SD_VARLINK_DEFINE_METHOD( static SD_VARLINK_DEFINE_METHOD(
ResolveAddress, ResolveAddress,
SD_VARLINK_FIELD_COMMENT("The Linux interface index for the network interface to search on. Typically left unspecified, in order to search on all interfaces."), SD_VARLINK_FIELD_COMMENT("The Linux interface index for the network interface to search on. Typically left unspecified, in order to search on all interfaces."),
@ -159,6 +168,15 @@ static SD_VARLINK_DEFINE_METHOD(
SD_VARLINK_DEFINE_OUTPUT_BY_TYPE(rrs, ResolvedRecord, SD_VARLINK_ARRAY), SD_VARLINK_DEFINE_OUTPUT_BY_TYPE(rrs, ResolvedRecord, SD_VARLINK_ARRAY),
SD_VARLINK_DEFINE_OUTPUT(flags, SD_VARLINK_INT, 0)); SD_VARLINK_DEFINE_OUTPUT(flags, SD_VARLINK_INT, 0));
static SD_VARLINK_DEFINE_METHOD(
StartBrowse,
SD_VARLINK_DEFINE_INPUT(domainName, SD_VARLINK_STRING, 0),
SD_VARLINK_DEFINE_INPUT(name, SD_VARLINK_STRING, SD_VARLINK_NULLABLE),
SD_VARLINK_DEFINE_INPUT(type, SD_VARLINK_STRING, SD_VARLINK_NULLABLE),
SD_VARLINK_DEFINE_INPUT(ifindex, SD_VARLINK_INT, 0),
SD_VARLINK_DEFINE_INPUT(flags, SD_VARLINK_INT, 0),
SD_VARLINK_DEFINE_OUTPUT_BY_TYPE(browser_service_data, ServiceData, SD_VARLINK_ARRAY));
static SD_VARLINK_DEFINE_ERROR(NoNameServers); static SD_VARLINK_DEFINE_ERROR(NoNameServers);
static SD_VARLINK_DEFINE_ERROR(NoSuchResourceRecord); static SD_VARLINK_DEFINE_ERROR(NoSuchResourceRecord);
static SD_VARLINK_DEFINE_ERROR(QueryTimedOut); static SD_VARLINK_DEFINE_ERROR(QueryTimedOut);
@ -198,6 +216,8 @@ SD_VARLINK_DEFINE_INTERFACE(
&vl_method_ResolveService, &vl_method_ResolveService,
SD_VARLINK_SYMBOL_COMMENT("Resolves a domain name to one or more DNS resource records."), SD_VARLINK_SYMBOL_COMMENT("Resolves a domain name to one or more DNS resource records."),
&vl_method_ResolveRecord, &vl_method_ResolveRecord,
SD_VARLINK_SYMBOL_COMMENT("Starts browsing for mDNS services of specified type."),
&vl_method_StartBrowse,
SD_VARLINK_SYMBOL_COMMENT("Encapsulates a resolved address."), SD_VARLINK_SYMBOL_COMMENT("Encapsulates a resolved address."),
&vl_type_ResolvedAddress, &vl_type_ResolvedAddress,
SD_VARLINK_SYMBOL_COMMENT("Encapsulates a resolved host name."), SD_VARLINK_SYMBOL_COMMENT("Encapsulates a resolved host name."),
@ -212,6 +232,7 @@ SD_VARLINK_DEFINE_INTERFACE(
&vl_type_ResourceRecord, &vl_type_ResourceRecord,
SD_VARLINK_SYMBOL_COMMENT("Encapsulates information about a resolved DNS resource record "), SD_VARLINK_SYMBOL_COMMENT("Encapsulates information about a resolved DNS resource record "),
&vl_type_ResolvedRecord, &vl_type_ResolvedRecord,
&vl_type_ServiceData,
&vl_error_NoNameServers, &vl_error_NoNameServers,
&vl_error_NoSuchResourceRecord, &vl_error_NoSuchResourceRecord,
&vl_error_QueryTimedOut, &vl_error_QueryTimedOut,

View File

@ -538,9 +538,53 @@ TEST(bind_mount_submounts) {
} }
TEST(path_is_network_fs_harder) { TEST(path_is_network_fs_harder) {
ASSERT_OK_ZERO(path_is_network_fs_harder("/dev")); _cleanup_close_ int dir_fd = -EBADF;
ASSERT_OK_ZERO(path_is_network_fs_harder("/sys")); int r;
ASSERT_OK_ZERO(path_is_network_fs_harder("/run"));
ASSERT_OK(dir_fd = open("/", O_PATH | O_CLOEXEC));
FOREACH_STRING(s,
"/", "/dev/", "/proc/", "/run/", "/sys/", "/tmp/", "/usr/", "/var/tmp/",
"", ".", "../../../", "/this/path/should/not/exist/for/test-mount-util/") {
r = path_is_network_fs_harder(s);
log_debug("path_is_network_fs_harder(%s) → %i: %s", s, r, r < 0 ? STRERROR(r) : yes_no(r));
const char *q = path_startswith(s, "/") ?: s;
r = path_is_network_fs_harder_at(dir_fd, q);
log_debug("path_is_network_fs_harder_at(root, %s) → %i: %s", q, r, r < 0 ? STRERROR(r) : yes_no(r));
}
if (geteuid() != 0 || have_effective_cap(CAP_SYS_ADMIN) <= 0) {
(void) log_tests_skipped("not running privileged");
return;
}
_cleanup_(rm_rf_physical_and_freep) char *t = NULL;
assert_se(mkdtemp_malloc("/tmp/test-mount-util.path_is_network_fs_harder.XXXXXXX", &t) >= 0);
r = safe_fork("(make_mount-point)",
FORK_RESET_SIGNALS |
FORK_CLOSE_ALL_FDS |
FORK_DEATHSIG_SIGTERM |
FORK_WAIT |
FORK_REOPEN_LOG |
FORK_LOG |
FORK_NEW_MOUNTNS |
FORK_MOUNTNS_SLAVE,
NULL);
ASSERT_OK(r);
if (r == 0) {
ASSERT_OK(mount_nofollow_verbose(LOG_INFO, "tmpfs", t, "tmpfs", 0, NULL));
ASSERT_OK_ZERO(path_is_network_fs_harder(t));
ASSERT_OK_ERRNO(umount(t));
ASSERT_OK(mount_nofollow_verbose(LOG_INFO, "tmpfs", t, "tmpfs", 0, "x-systemd-growfs,x-systemd-automount"));
ASSERT_OK_ZERO(path_is_network_fs_harder(t));
ASSERT_OK_ERRNO(umount(t));
_exit(EXIT_SUCCESS);
}
} }
DEFINE_TEST_MAIN(LOG_DEBUG); DEFINE_TEST_MAIN(LOG_DEBUG);

View File

@ -522,6 +522,7 @@ static int reply_callback(
if (!arg_quiet) if (!arg_quiet)
sd_json_variant_dump(parameters, arg_json_format_flags, stdout, NULL); sd_json_variant_dump(parameters, arg_json_format_flags, stdout, NULL);
fflush(stdout);
return r; return r;
} }

View File

@ -0,0 +1,6 @@
# SPDX-License-Identifier: LGPL-2.1-or-later
all setup run clean clean-again:
@TEST_BASE_DIR=../ ./test.sh --$@
.PHONY: all setup run clean clean-again

View File

@ -0,0 +1,8 @@
# SPDX-License-Identifier: LGPL-2.1-or-later
integration_tests += [
integration_test_template + {
'name' : fs.name(meson.current_source_dir()),
'vm' : true,
},
]

View File

@ -0,0 +1,12 @@
#!/usr/bin/env bash
# SPDX-License-Identifier: LGPL-2.1-or-later
set -e
TEST_DESCRIPTION="Test for systemd-resolved's mDNS functionality"
IMAGE_NAME="resolved-mdns"
TEST_NO_NSPAWN=1
# shellcheck source=test/test-functions
. "${TEST_BASE_DIR:?}/test-functions"
do_test "$@"

View File

@ -142,11 +142,13 @@ endif
############################################################ ############################################################
if install_tests if install_tests
foreach script : ['integration-test-setup.sh', 'run-unit-tests.py'] install_data('run-unit-tests.py',
install_data(script, install_mode : 'rwxr-xr-x',
install_mode : 'rwxr-xr-x', install_dir : testsdir)
install_dir : testsdir)
endforeach install_data('integration-test-setup.sh',
install_mode : 'rwxr-xr-x',
install_dir : testdata_dir)
endif endif
############################################################ ############################################################
@ -377,6 +379,7 @@ foreach dirname : [
'TEST-84-STORAGETM', 'TEST-84-STORAGETM',
'TEST-85-NETWORK', 'TEST-85-NETWORK',
'TEST-86-MULTI-PROFILE-UKI', 'TEST-86-MULTI-PROFILE-UKI',
'TEST-87-RESOLVED-MDNS',
] ]
subdir(dirname) subdir(dirname)
endforeach endforeach

View File

@ -80,6 +80,7 @@ show_journal = True # When true, show journal on stopping networkd.
active_units = [] active_units = []
protected_links = { protected_links = {
'br0',
'erspan0', 'erspan0',
'gre0', 'gre0',
'gretap0', 'gretap0',

View File

@ -7,9 +7,9 @@ Before=getty-pre.target
[Service] [Service]
ExecStartPre=rm -f /failed /testok ExecStartPre=rm -f /failed /testok
ExecStartPre=/usr/lib/systemd/tests/integration-test-setup.sh setup ExecStartPre=/usr/lib/systemd/tests/testdata/integration-test-setup.sh setup
ExecStart=@command@ ExecStart=@command@
ExecStopPost=/usr/lib/systemd/tests/integration-test-setup.sh finalize ExecStopPost=/usr/lib/systemd/tests/testdata/integration-test-setup.sh finalize
Type=oneshot Type=oneshot
MemoryAccounting=@memory-accounting@ MemoryAccounting=@memory-accounting@
StateDirectory=%N StateDirectory=%N

View File

@ -132,10 +132,12 @@ testcase_unpriv() {
return 0 return 0
fi fi
# The kernel has a restriction for unprivileged user namespaces where they cannot mount a less restrictive # IMPORTANT: For /proc/ to be remounted in pid namespace within an unprivileged user namespace, there needs to
# instance of /proc/. So if /proc/ is masked (e.g. /proc/kmsg is over-mounted with tmpfs as systemd-nspawn does), # be at least 1 unmasked procfs mount in ANY directory. Otherwise, if /proc/ is masked (e.g. /proc/scsi is
# then mounting a new /proc/ will fail and we will still see the host's /proc/. Thus, to allow tests to run in # over-mounted with tmpfs), then mounting a new /proc/ will fail.
# a VM or nspawn, we mount a new proc on a temporary directory with no masking to bypass this kernel restriction. #
# Thus, to guarantee PrivatePIDs=yes tests for unprivileged users pass, we mount a new procfs on a temporary
# directory with no masking. This will guarantee an unprivileged user can mount a new /proc/ successfully.
mkdir -p /tmp/TEST-07-PID1-private-pids-proc mkdir -p /tmp/TEST-07-PID1-private-pids-proc
mount -t proc proc /tmp/TEST-07-PID1-private-pids-proc mount -t proc proc /tmp/TEST-07-PID1-private-pids-proc
@ -146,7 +148,16 @@ testcase_unpriv() {
umount /tmp/TEST-07-PID1-private-pids-proc umount /tmp/TEST-07-PID1-private-pids-proc
rm -rf /tmp/TEST-07-PID1-private-pids-proc rm -rf /tmp/TEST-07-PID1-private-pids-proc
# Now verify the behavior with masking - units should fail as PrivatePIDs=yes has no graceful fallback. # Now we will mask /proc/ by mounting tmpfs over /proc/scsi. This will guarantee that mounting /proc/ will fail
# for unprivileged users when using PrivatePIDs=yes. Now units should fail as PrivatePIDs=yes has no graceful
# fallback.
#
# Note some kernels do not have /proc/scsi so we verify the directory exists prior to running the test.
if [ ! -d /proc/scsi ]; then
echo "/proc/scsi does not exist, skipping unprivileged PrivatePIDs=yes test with masked /proc/"
return 0
fi
if [[ "$HAS_EXISTING_SCSI_MOUNT" == "no" ]]; then if [[ "$HAS_EXISTING_SCSI_MOUNT" == "no" ]]; then
mount -t tmpfs tmpfs /proc/scsi mount -t tmpfs tmpfs /proc/scsi
fi fi

View File

@ -0,0 +1,8 @@
# SPDX-License-Identifier: LGPL-2.1-or-later
[Unit]
Description=TEST-87-RESOLVED-MDNS
[Service]
ExecStartPre=rm -f /failed /testok
ExecStart=/usr/lib/systemd/tests/testdata/units/%N.sh
Type=oneshot

View File

@ -0,0 +1,255 @@
#!/usr/bin/env bash
# SPDX-License-Identifier: LGPL-2.1-or-later
set -eux
set -o pipefail
# shellcheck source=test/units/test-control.sh
. "$(dirname "$0")"/test-control.sh
SERVICE_TYPE_COUNT=10
SERVICE_COUNT=20
CONTAINER_ZONE="test-$RANDOM"
CONTAINER_1="test-mdns-1"
CONTAINER_2="test-mdns-2"
# Prepare containers
create_container() {
local container="${1:?}"
local stype sid svc
# Prepare container's /etc
#
# Since we also need the various test suite related dropins from the host's /etc,
# we'll overlay our customizations on top of that
mkdir -p "/var/lib/machines/$container/etc/systemd/dnssd"
# Create 20 test services for each service type (_testServiceX._udp) and number them sequentially,
# i.e. create services 0-19 for _testService0._udp, services 20-39 for _testService1._udp, and so on
for stype in $(seq 0 $((SERVICE_TYPE_COUNT - 1))); do
for sid in $(seq 0 $((SERVICE_COUNT - 1))); do
svc=$((stype * SERVICE_COUNT + sid))
cat >"/var/lib/machines/$container/etc/systemd/dnssd/test-service-$container-$svc.dnssd" <<EOF
[Service]
Name=Test Service $svc on %H
Type=_testService$stype._udp
Port=24002
TxtText=DC=Monitor PN=867313 SN=XZ051Z0051
EOF
done
done
# To make things fast, spawn the container with a transient version of what's currently the host's
# rootfs, sans a couple of tweaks to make the container unique enough
mkdir -p "/run/systemd/system/systemd-nspawn@$container.service.d"
cat >"/run/systemd/system/systemd-nspawn@$container.service.d/override.conf" <<EOF
[Service]
ExecStart=
ExecStart=systemd-nspawn --quiet --link-journal=try-guest --keep-unit --machine=%i --boot \
--volatile=yes --directory=/ \
--inaccessible=/etc/machine-id \
--inaccessible=/etc/hostname \
--resolv-conf=replace-stub \
--network-zone=$CONTAINER_ZONE \
--overlay=/etc:/var/lib/machines/$container/etc::/etc \
--hostname=$container
EOF
}
check_both() {
local service_id="${1:?}"
local result_file="${2:?}"
# We should get 20 services per container, 40 total
if [[ "$(wc -l <"$result_file")" -ge 40 ]]; then
# Check if the services we got are the correct ones
for i in $(seq 0 $((SERVICE_TYPE_COUNT - 1))); do
svc=$((service_id * SERVICE_COUNT + i))
if ! grep "Test Service $svc on $CONTAINER_1" "$result_file" || \
! grep "Test Service $svc on $CONTAINER_2" "$result_file"; then
return 1
fi
done
# We got all records and all of them are what we expect
return 0
fi
return 1
}
check_first() {
local service_id="${1:?}"
local result_file="${2:?}"
# We should get 20 services per container
if [[ "$(wc -l <"$result_file")" -ge 20 ]]; then
# Check if the services we got are the correct ones
for i in $(seq 0 $((SERVICE_TYPE_COUNT - 1))); do
svc=$((service_id * SERVICE_COUNT + i))
if ! grep "Test Service $svc on $CONTAINER_1" "$result_file"; then
return 1
fi
# This check assumes the second container is unreachable, so this shouldn't happen
if grep "Test Service $svc on $CONTAINER_2" "$result_file"; then
echo >&2 "Found a record from an unreachable container"
cat "$result_file"
exit 1
fi
done
# We got all records and all of them are what we expect
return 0
fi
return 1
}
run_and_check_services() {
local service_id="${1:?}"
local check_func="${2:?}"
local unit_name="varlinkctl-$service_id-$SRANDOM.service"
local i out_file parameters service_type svc tmp_file
out_file="$(mktemp)"
error_file="$(mktemp)"
tmp_file="$(mktemp)"
service_type="_testService$service_id._udp"
parameters="{ \"domainName\": \"$service_type.local\", \"name\": \"\", \"type\": \"\", \"ifindex\": ${BRIDGE_INDEX:?}, \"flags\": 16785432 }"
systemd-run --unit="$unit_name" --service-type=exec -p StandardOutput="file:$out_file" -p StandardError="file:$error_file" \
varlinkctl call --more /run/systemd/resolve/io.systemd.Resolve io.systemd.Resolve.StartBrowse "$parameters"
# shellcheck disable=SC2064
# Note: unregister the trap once it's fired, otherwise it'll get propagated to functions that call this
# one, *sigh*
trap "trap - RETURN; systemctl stop $unit_name" RETURN
for _ in {0..14}; do
# The response format, for reference (it's JSON-SEQ):
#
# {
# "browser_service_data": [
# {
# "add_flag": true,
# "family": 10,
# "name": "Test Service 13 on test-mdns-1",
# "type": "_testService0._udp",
# "domain": "local",
# "interface": 3
# },
# ...
# ]
# }
if [[ -s "$out_file" ]]; then
# Extract the service name from each valid record...
# jq --slurp --raw-output \
# ".[].browser_service_data[] | select(.add_flag == true and .type == \"$service_type\" and .family == 10).name" "$out_file" | sort | tee "$tmp_file"
grep -o '"name":"[^"]*"' "$out_file" | sed 's/"name":"//;s/"//g' | sort | tee "$tmp_file"
# ...and compare them with what we expect
if "$check_func" "$service_id" "$tmp_file"; then
return 0
fi
fi
sleep 2
done
cat "$out_file"
cat "$error_file"
return 1
}
testcase_all_sequential() {
: "Test each service type (sequentially)"
resolvectl flush-caches
for id in $(seq 0 $((SERVICE_TYPE_COUNT - 1))); do
run_and_check_services "$id" check_both
done
echo testcase_end
}
testcase_all_parallel() {
: "Test each service type (in parallel)"
resolvectl flush-caches
for id in $(seq 0 $((SERVICE_TYPE_COUNT - 1))); do
run_and_check_services "$id" check_both &
done
wait
}
testcase_single_service_multiple_times() {
: "Test one service type multiple times"
resolvectl flush-caches
for _ in {0..4}; do
run_and_check_services 4 check_both
done
}
testcase_second_unreachable() {
: "Test each service type while the second container is unreachable"
resolvectl flush-caches
systemd-run -M "$CONTAINER_2" --wait --pipe -- networkctl down host0
for id in $(seq 0 $((SERVICE_TYPE_COUNT - 1))); do
run_and_check_services "$id" check_first
done
: "Test each service type after bringing the second container back up again"
systemd-run -M "$CONTAINER_2" --wait --pipe -- networkctl up host0
systemd-run -M "$CONTAINER_2" --wait --pipe -- \
/usr/lib/systemd/systemd-networkd-wait-online --ipv4 --ipv6 --interface=host0 --operational-state=degraded --timeout=30
for id in $(seq 0 $((SERVICE_TYPE_COUNT - 1))); do
run_and_check_services "$id" check_both
done
}
: "Setup host & containers"
# Note: create the drop-in intentionally under /run/ and copy it manually into the containers
mkdir -p /run/systemd/resolved.conf.d/
cat >/run/systemd/resolved.conf.d/99-mdns-llmnr.conf <<EOF
[Resolve]
MulticastDNS=yes
LLMNR=yes
EOF
systemctl unmask systemd-resolved.service systemd-networkd.{service,socket} systemd-machined.service
systemctl enable --now systemd-resolved.service systemd-networkd.{socket,service} systemd-machined.service
ln -svrf /run/systemd/resolved.conf.d/99-mdns-llmnr.conf /etc/resolv.conf
systemctl reload systemd-resolved.service systemd-networkd.service
for container in "$CONTAINER_1" "$CONTAINER_2"; do
create_container "$container"
mkdir -p "/var/lib/machines/$container/etc/systemd/resolved.conf.d/"
cp /run/systemd/resolved.conf.d/99-mdns-llmnr.conf "/var/lib/machines/$container/etc/systemd/resolved.conf.d/"
touch "/var/lib/machines/$container/etc/hostname"
systemctl daemon-reload
machinectl start "$container"
# Wait for the system bus to start...
timeout 30s bash -xec "while ! systemd-run -M '$container' --wait --pipe true; do sleep 1; done"
# ...and from there wait for the machine bootup to finish. We don't really care if the container
# boots up in a degraded state, hence the `:`
timeout 30s systemd-run -M "$container" --wait --pipe -- systemctl --wait is-system-running || :
# Wait until the veth interface is configured and turn on mDNS and LLMNR
systemd-run -M "$container" --wait --pipe -- \
/usr/lib/systemd/systemd-networkd-wait-online --ipv4 --ipv6 --interface=host0 --operational-state=degraded --timeout=30
systemd-run -M "$container" --wait --pipe -- resolvectl mdns host0 yes
systemd-run -M "$container" --wait --pipe -- resolvectl llmnr host0 yes
systemd-run -M "$container" --wait --pipe -- networkctl status --no-pager
systemd-run -M "$container" --wait --pipe -- resolvectl status --no-pager
[[ "$(systemd-run -M "$container" --wait --pipe -- resolvectl mdns host0)" =~ :\ yes$ ]]
[[ "$(systemd-run -M "$container" --wait --pipe -- resolvectl llmnr host0)" =~ :\ yes$ ]]
done
BRIDGE_INDEX="$(<"/sys/class/net/vz-$CONTAINER_ZONE/ifindex")"
machinectl list
resolvectl mdns "vz-$CONTAINER_ZONE" on
resolvectl llmnr "vz-$CONTAINER_ZONE" on
networkctl status
resolvectl status
# Run the actual test cases (functions prefixed by testcase_)
run_testcases
touch /testok