generators: fix parameters naming in symlink helper

Coverity gets confused because the names were swapped. The parameters
are all passed in the right position, so there's no functional issue,
but the naming is confusing and trips static analyzers, so fix it.

CID#1621624

Follow-up for 8a9ab3dbbc86cf72ef8f511a3214f66a61f6bd01

hwdb.d/70-software-radio.hwdb

@@ -107,13 +107,6 @@ usb:v0525p3380*
 usb:v04B4p325C*
  ID_SOFTWARE_RADIO=1
 
-##########################################
-# MiriSDR
-##########################################
-# Mirics MSi2500 default (e.g. VTX3D card)
-usb:v1DF7p2500*
- ID_SOFTWARE_RADIO=1
-
 ##########################################
 # Nuand
 ##########################################
@@ -299,3 +292,34 @@ usb:v1F4DpD286*
 # PROlectrix DV107669 (FC0012)
 usb:v1F4DpD803*
  ID_SOFTWARE_RADIO=1
+
+##########################################
+# SDRplay
+##########################################
+# RSP1
+usb:v1DF7p2500*
+ ID_SOFTWARE_RADIO=1
+
+# RSP1A
+usb:v1DF7p3000*
+ ID_SOFTWARE_RADIO=1
+
+# RSP2/RSP2pro
+usb:v1DF7p3010*
+ ID_SOFTWARE_RADIO=1
+
+# RSPduo
+usb:v1DF7p3020*
+ ID_SOFTWARE_RADIO=1
+
+# RSPdx
+usb:v1DF7p3030*
+ ID_SOFTWARE_RADIO=1
+
+# RSP1B
+usb:v1DF7p3050*
+ ID_SOFTWARE_RADIO=1
+
+# RSPdxR2
+usb:v1DF7p3060*
+ ID_SOFTWARE_RADIO=1

man/systemd-userdbd.service.xml

@@ -35,7 +35,7 @@
     compatibility. It may also pick up statically defined JSON user/group records from files in
     <filename>/etc/userdb/</filename>, <filename>/run/userdb/</filename>,
     <filename>/run/host/userdb/</filename> and <filename>/usr/lib/userdb/</filename> with the
-    <literal>.user</literal> extension.</para>
+    <literal>.user</literal> or <literal>.group</literal> extension.</para>
 
     <para>Most of <command>systemd-userdbd</command>'s functionality is accessible through the
     <citerefentry><refentrytitle>userdbctl</refentrytitle><manvolnum>1</manvolnum></citerefentry>

src/shared/generator.c

@@ -26,11 +26,11 @@
 #include "tmpfile-util.h"
 #include "unit-name.h"
 
-static int symlink_unless_exists(const char *to, const char *from) {
+static int symlink_unless_exists(const char *from, const char *to) {
-        (void) mkdir_parents(from, 0755);
+        (void) mkdir_parents(to, 0755);
 
-        if (symlink(to, from) < 0 && errno != EEXIST)
+        if (symlink(from, to) < 0 && errno != EEXIST)
-                return log_error_errno(errno, "Failed to create symlink %s: %m", from);
+                return log_error_errno(errno, "Failed to create symlink %s: %m", to);
         return 0;
 }