Replace underscores in filenames with hyphens (#38203)

.github/workflows/build-test.yml

@@ -41,4 +41,4 @@ jobs:
       - name: Repository checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - name: Build check
-        run: .github/workflows/build_test.sh
+        run: .github/workflows/build-test.sh

.github/workflows/codeql.yml

@@ -50,7 +50,7 @@ jobs:
         languages: ${{ matrix.language }}
         config-file: ./.github/codeql-config.yml
 
-    - run: sudo -E .github/workflows/unit_tests.sh SETUP
+    - run: sudo -E .github/workflows/unit-tests.sh SETUP
 
     - name: Autobuild
       uses: github/codeql-action/autobuild@181d5eefc20863364f96762470ba6f862bdef56b

.github/workflows/coverity.yml

@@ -25,6 +25,6 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       # Reuse the setup phase of the unit test script to avoid code duplication
       - name: Install build dependencies
-        run: sudo -E .github/workflows/unit_tests.sh SETUP
+        run: sudo -E .github/workflows/unit-tests.sh SETUP
       - name: Build & upload the results
         run: tools/coverity.sh

.github/workflows/unit-tests.yml

@@ -44,6 +44,6 @@ jobs:
           sudo sed -i '/^XDG_/d' /etc/environment
           # Pass only specific env variables through sudo, to avoid having
           # the already existing XDG_* stuff on the "other side"
-          sudo --preserve-env=GITHUB_ACTIONS,CI .github/workflows/unit_tests.sh SETUP
+          sudo --preserve-env=GITHUB_ACTIONS,CI .github/workflows/unit-tests.sh SETUP
       - name: Build & test
-        run: sudo --preserve-env=GITHUB_ACTIONS,CI .github/workflows/unit_tests.sh RUN_${{ matrix.run_phase }}
+        run: sudo --preserve-env=GITHUB_ACTIONS,CI .github/workflows/unit-tests.sh RUN_${{ matrix.run_phase }}

src/basic/parse-util.c

@@ -11,7 +11,7 @@
 #include "extract-word.h"
 #include "locale-util.h"
 #include "log.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "parse-util.h"
 #include "process-util.h"
 #include "string-util.h"

src/basic/socket-util.h

@@ -12,7 +12,7 @@
 
 #include "forward.h"
 #include "memory-util.h"
-#include "missing_network.h"
+#include "missing-network.h"
 
 union sockaddr_union {
         /* The minimal, abstract version */

src/boot/meson.build

@@ -147,7 +147,7 @@ if efi_conf.get('SBAT_DISTRO', '') != ''
 endif
 
 configure_file(
-        output : 'efi_config.h',
+        output : 'efi-config.h',
         configuration : efi_conf)
 
 ############################################################
@@ -163,7 +163,7 @@ efi_c_args = [
         '-ffreestanding',
         '-fno-strict-aliasing',
         '-fshort-wchar',
-        '-include', 'efi_config.h',
+        '-include', 'efi-config.h',
 ]
 
 efi_c_args += cc.get_supported_arguments(

src/core/bpf-restrict-fs.c

@@ -17,7 +17,7 @@
 /* libbpf, clang and llc compile time dependencies are satisfied */
 #include "bpf-dlopen.h"
 #include "bpf-link.h"
-#include "bpf/restrict_fs/restrict-fs-skel.h"
+#include "bpf/restrict-fs/restrict-fs-skel.h"
 
 #define CGROUP_HASH_SIZE_MAX 2048
 

src/core/bpf-restrict-ifaces.c

@@ -16,7 +16,7 @@
 
 #include "bpf-dlopen.h"
 #include "bpf-link.h"
-#include "bpf/restrict_ifaces/restrict-ifaces-skel.h"
+#include "bpf/restrict-ifaces/restrict-ifaces-skel.h"
 
 static struct restrict_ifaces_bpf *restrict_ifaces_bpf_free(struct restrict_ifaces_bpf *obj) {
         restrict_ifaces_bpf__destroy(obj);

src/core/bpf-socket-bind.c

@@ -11,8 +11,8 @@
 /* libbpf, clang, llvm and bpftool compile time dependencies are satisfied */
 #include "bpf-dlopen.h"
 #include "bpf-link.h"
-#include "bpf/socket_bind/socket-bind-api.bpf.h"
-#include "bpf/socket_bind/socket-bind-skel.h"
+#include "bpf/socket-bind/socket-bind-api.bpf.h"
+#include "bpf/socket-bind/socket-bind-skel.h"
 
 static struct socket_bind_bpf *socket_bind_bpf_free(struct socket_bind_bpf *obj) {
         /* socket_bind_bpf__destroy handles object == NULL case */

src/core/bpf/restrict-fs/restrict-fs-skel.h

@@ -13,4 +13,4 @@
 #define bpf_object__load_skeleton sym_bpf_object__load_skeleton
 #define bpf_object__destroy_skeleton sym_bpf_object__destroy_skeleton
 
-#include "bpf/restrict_fs/restrict-fs.skel.h"
+#include "bpf/restrict-fs/restrict-fs.skel.h"

src/core/bpf/restrict-ifaces/restrict-ifaces-skel.h

@@ -13,4 +13,4 @@
 #define bpf_object__load_skeleton sym_bpf_object__load_skeleton
 #define bpf_object__destroy_skeleton sym_bpf_object__destroy_skeleton
 
-#include "bpf/restrict_ifaces/restrict-ifaces.skel.h"
+#include "bpf/restrict-ifaces/restrict-ifaces.skel.h"

src/core/bpf/socket-bind/socket-bind-skel.h

@@ -13,4 +13,4 @@
 #define bpf_object__load_skeleton sym_bpf_object__load_skeleton
 #define bpf_object__destroy_skeleton sym_bpf_object__destroy_skeleton
 
-#include "bpf/socket_bind/socket-bind.skel.h"
+#include "bpf/socket-bind/socket-bind.skel.h"

src/core/cgroup.c

@@ -54,7 +54,7 @@
 #include "bpf-dlopen.h"
 #include "bpf-link.h"
 #include "bpf-restrict-fs.h"
-#include "bpf/restrict_fs/restrict-fs-skel.h"
+#include "bpf/restrict-fs/restrict-fs-skel.h"
 #endif
 
 #define CGROUP_CPU_QUOTA_DEFAULT_PERIOD_USEC (100 * USEC_PER_MSEC)

src/core/meson.build

@@ -70,9 +70,9 @@ libcore_sources = files(
         'varlink-unit.c',
 )
 
-subdir('bpf/socket_bind')
-subdir('bpf/restrict_fs')
-subdir('bpf/restrict_ifaces')
+subdir('bpf/socket-bind')
+subdir('bpf/restrict-fs')
+subdir('bpf/restrict-ifaces')
 
 if conf.get('BPF_FRAMEWORK') == 1
         libcore_sources += [

src/libsystemd/sd-netlink/netlink-types-genl.c

@@ -11,7 +11,7 @@
 #include <linux/wireguard.h>
 #include <netinet/in.h>
 
-#include "missing_network.h"
+#include "missing-network.h"
 #include "netlink-genl.h"
 #include "netlink-types-internal.h"
 

src/libsystemd/sd-netlink/netlink-types-rtnl.c

@@ -19,7 +19,7 @@
 #include <netinet/in.h>
 #include <sys/socket.h>
 
-#include "missing_network.h"
+#include "missing-network.h"
 #include "netlink-types-internal.h"
 
 enum {

src/libsystemd/sd-netlink/test-netlink.c

@@ -17,7 +17,7 @@
 
 #include "alloc-util.h"
 #include "fd-util.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "netlink-genl.h"
 #include "netlink-internal.h"
 #include "netlink-sock-diag.h"

src/login/logind-session-device.c

@@ -22,7 +22,7 @@
 #include "logind-session.h"
 #include "logind-session-dbus.h"
 #include "logind-session-device.h"
-#include "missing_drm.h"
+#include "missing-drm.h"
 #include "string-util.h"
 
 enum SessionDeviceNotifications {

src/network/bpf/sysctl-monitor/sysctl-monitor-skel.h

@@ -13,4 +13,4 @@
 #define bpf_object__load_skeleton sym_bpf_object__load_skeleton
 #define bpf_object__open_skeleton sym_bpf_object__open_skeleton
 
-#include "bpf/sysctl_monitor/sysctl-monitor.skel.h"
+#include "bpf/sysctl-monitor/sysctl-monitor.skel.h"

src/network/meson.build

@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: LGPL-2.1-or-later
 
-subdir('bpf/sysctl_monitor')
+subdir('bpf/sysctl-monitor')
 
 systemd_networkd_sources = files(
         'networkd.c'

src/network/netdev/tunnel.c

@@ -10,7 +10,7 @@
 #include "alloc-util.h"
 #include "conf-parser.h"
 #include "hexdecoct.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "netlink-util.h"
 #include "networkd-manager.h"
 #include "parse-util.h"

src/network/netdev/xfrm.c

@@ -4,7 +4,7 @@
 
 #include "sd-netlink.h"
 
-#include "missing_network.h"
+#include "missing-network.h"
 #include "networkd-link.h"
 #include "xfrm.h"
 

src/network/networkd-ndisc.c

@@ -12,7 +12,7 @@
 #include "conf-parser.h"
 #include "errno-util.h"
 #include "event-util.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "ndisc-router-internal.h"
 #include "networkd-address.h"
 #include "networkd-address-generation.h"

src/network/networkd-netlabel.c

@@ -2,7 +2,7 @@
 
 #include "sd-netlink.h"
 
-#include "missing_network.h"
+#include "missing-network.h"
 #include "netlink-util.h"
 #include "networkd-address.h"
 #include "networkd-link.h"

src/network/networkd-setlink.c

@@ -7,7 +7,7 @@
 #include "sd-netlink.h"
 
 #include "device-private.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "netif-util.h"
 #include "netlink-util.h"
 #include "networkd-address.h"

src/network/networkd-sysctl.c

@@ -29,8 +29,8 @@
 #if HAVE_VMLINUX_H
 
 #include "bpf-link.h"
-#include "bpf/sysctl_monitor/sysctl-monitor-skel.h"
-#include "bpf/sysctl_monitor/sysctl-write-event.h"
+#include "bpf/sysctl-monitor/sysctl-monitor-skel.h"
+#include "bpf/sysctl-monitor/sysctl-write-event.h"
 
 static struct sysctl_monitor_bpf* sysctl_monitor_bpf_free(struct sysctl_monitor_bpf *obj) {
         sysctl_monitor_bpf__destroy(obj);

src/nsresourced/bpf/userns-restrict/userns-restrict-skel.h

@@ -14,4 +14,4 @@
 #define bpf_object__load_skeleton sym_bpf_object__load_skeleton
 #define bpf_object__open_skeleton sym_bpf_object__open_skeleton
 
-#include "bpf/userns_restrict/userns-restrict.skel.h"
+#include "bpf/userns-restrict/userns-restrict.skel.h"

src/nsresourced/meson.build

@@ -4,7 +4,7 @@ if conf.get('ENABLE_NSRESOURCED') != 1
         subdir_done()
 endif
 
-subdir('bpf/userns_restrict')
+subdir('bpf/userns-restrict')
 
 systemd_nsresourced_sources = files(
         'nsresourced-manager.c',

src/nsresourced/userns-restrict.h

@@ -4,7 +4,7 @@
 #include "forward.h"
 
 #if HAVE_VMLINUX_H
-#include "bpf/userns_restrict/userns-restrict-skel.h"
+#include "bpf/userns-restrict/userns-restrict-skel.h"
 #else
 struct userns_restrict_bpf;
 #endif

src/resolve/resolvectl.c

@@ -30,7 +30,7 @@
 #include "hostname-util.h"
 #include "json-util.h"
 #include "main-func.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "netlink-util.h"
 #include "openssl-util.h"
 #include "pager.h"

src/resolve/resolved-dns-stream.c

@@ -9,7 +9,7 @@
 #include "fd-util.h"
 #include "iovec-util.h"
 #include "log.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "ordered-set.h"
 #include "resolved-dns-packet.h"
 #include "resolved-dns-server.h"

src/resolve/resolved-dns-stub.c

@@ -11,7 +11,7 @@
 #include "errno-util.h"
 #include "fd-util.h"
 #include "log.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "resolve-util.h"
 #include "resolved-dns-answer.h"
 #include "resolved-dns-packet.h"

src/resolve/resolved-dns-synthesize.c

@@ -7,7 +7,7 @@
 #include "hostname-util.h"
 #include "local-addresses.h"
 #include "log.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "resolved-def.h"
 #include "resolved-dns-answer.h"
 #include "resolved-dns-packet.h"

src/resolve/resolved-manager.c

@@ -24,7 +24,7 @@
 #include "iovec-util.h"
 #include "json-util.h"
 #include "memstream-util.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "ordered-set.h"
 #include "parse-util.h"
 #include "random-util.h"

src/shared/bpf-dlopen.h

@@ -26,7 +26,7 @@ extern DLSYM_PROTOTYPE(bpf_map_get_fd_by_id);
 extern DLSYM_PROTOTYPE(bpf_map_lookup_elem);
 extern DLSYM_PROTOTYPE(bpf_map_update_elem);
 /* The *_skeleton APIs are autogenerated by bpftool, the targets can be found
- * in ./build/src/core/bpf/socket_bind/socket-bind.skel.h */
+ * in ./build/src/core/bpf/socket-bind/socket-bind.skel.h */
 extern DLSYM_PROTOTYPE(bpf_object__attach_skeleton);
 extern DLSYM_PROTOTYPE(bpf_object__destroy_skeleton);
 extern DLSYM_PROTOTYPE(bpf_object__detach_skeleton);

src/shared/conf-parser.c

@@ -24,7 +24,7 @@
 #include "in-addr-prefix-util.h"
 #include "ip-protocol-list.h"
 #include "log.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "nulstr-util.h"
 #include "parse-helpers.h"
 #include "parse-util.h"

src/shared/loopback-setup.c

@@ -7,7 +7,7 @@
 #include "errno-util.h"
 #include "log.h"
 #include "loopback-setup.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "time-util.h"
 
 #define LOOPBACK_SETUP_TIMEOUT_USEC (5 * USEC_PER_SEC)

src/test/test-sbat.c

@@ -1,8 +1,8 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
-/* We include efi_config.h after undefining PROJECT_VERSION which is also defined in config.h. */
+/* We include efi-config.h after undefining PROJECT_VERSION which is also defined in config.h. */
 #undef PROJECT_VERSION
-#include "efi_config.h"
+#include "efi-config.h"
 #include "sbat.h"
 #include "tests.h"
 

src/test/test-socket-netlink.c

@@ -4,7 +4,7 @@
 
 #include "alloc-util.h"
 #include "fd-util.h"
-#include "missing_network.h"
+#include "missing-network.h"
 #include "socket-netlink.h"
 #include "socket-util.h"
 #include "string-util.h"