docs/CODING_STYLE.md

@@ -67,18 +67,6 @@ SPDX-License-Identifier: LGPL-2.1-or-later
   const char *foo(const char *input);
   ```
 
-- Casts should be written like this:
-
-  ```c
-  (const char*) s;
-  ```
-
-  instead of this:
-
-  ```c
-  (const char *)s;
-  ```
-
 - Single-line `if` blocks should not be enclosed in `{}`. Write this:
 
   ```c

src/core/exec-invoke.c

@@ -5732,7 +5732,7 @@ int exec_invoke(
 
         /* We need setresuid() if the caller asked us to apply sandboxing and the command isn't explicitly
          * excepted from either whole sandboxing or just setresuid() itself. */
-        needs_setuid = needs_sandboxing && !FLAGS_SET(command->flags, EXEC_COMMAND_NO_SETUID);
+        needs_setuid = (params->flags & EXEC_APPLY_SANDBOXING) && !(command->flags & (EXEC_COMMAND_FULLY_PRIVILEGED|EXEC_COMMAND_NO_SETUID));
 
         uint64_t capability_ambient_set = context->capability_ambient_set;
 

src/core/selinux-setup.c

@@ -19,10 +19,8 @@ int mac_selinux_setup(bool *loaded_policy) {
         int r;
 
         r = dlopen_libselinux();
-        if (r < 0) {
+        if (r < 0)
-                log_debug_errno(r, "No SELinux library available, skipping setup.");
+                return log_debug_errno(r, "No SELinux library available, skipping setup: %m");
-                return 0;
-        }
 
         mac_selinux_disable_logging();