1
0
mirror of https://github.com/systemd/systemd synced 2025-09-28 16:24:45 +02:00

Compare commits

...

7 Commits

Author SHA1 Message Date
Lennart Poettering
14f7d087cc update TODO 2021-01-14 14:15:48 +01:00
krissgjeng
081d8706de hwdb: add Cube Mix Plus (i18B) rotation info
Added Cube Mix Plus (i18B) Rotation information.
Also Combined the sensor lines with the different Cube i7 stylus models because they use the same ACCEL_MOUNT_MATRIX
2021-01-14 11:01:42 +01:00
Luca Boccassi
c17b2155e5
Merge pull request #18226 from mrc0mmand/actions-flake-workarounds
ci: assorted workarounds for recent flakes
2021-01-14 10:00:24 +00:00
Frantisek Sumsal
e8fd7c9ed4 ci: introduce a watchdog for the sanitized unit test run 2021-01-13 22:32:30 +01:00
Frantisek Sumsal
f1a8fed286 ci: skip test-execute on GH Actions under ASan
It seems to suffer from the same issue as on Travis CI, where the test
randomly fails due to timeouts in its subtests.

See: https://github.com/systemd/systemd/issues/10696#issuecomment-758501797
2021-01-13 21:59:48 +01:00
Frantisek Sumsal
56a017cb0d ci: optimize the sanitized build under gcc as well 2021-01-13 21:51:44 +01:00
Frantisek Sumsal
b5a9b601c3 ci: drop the unbuffer workaround
It actually didn't do anything, the issue was somewhere else.
2021-01-12 22:13:33 +01:00
4 changed files with 28 additions and 17 deletions

View File

@ -47,13 +47,15 @@ for phase in "${PHASES[@]}"; do
meson test -C build --print-errorlogs meson test -C build --print-errorlogs
;; ;;
RUN_ASAN_UBSAN|RUN_GCC_ASAN_UBSAN|RUN_CLANG_ASAN_UBSAN) RUN_ASAN_UBSAN|RUN_GCC_ASAN_UBSAN|RUN_CLANG_ASAN_UBSAN)
MESON_ARGS=(--optimization=1)
if [[ "$phase" = "RUN_CLANG_ASAN_UBSAN" ]]; then if [[ "$phase" = "RUN_CLANG_ASAN_UBSAN" ]]; then
export CC=clang export CC=clang
export CXX=clang++ export CXX=clang++
# Build fuzzer regression tests only with clang (for now), # Build fuzzer regression tests only with clang (for now),
# see: https://github.com/systemd/systemd/pull/15886#issuecomment-632689604 # see: https://github.com/systemd/systemd/pull/15886#issuecomment-632689604
# -Db_lundef=false: See https://github.com/mesonbuild/meson/issues/764 # -Db_lundef=false: See https://github.com/mesonbuild/meson/issues/764
MESON_ARGS=(-Db_lundef=false -Dfuzz-tests=true --optimization=1) MESON_ARGS+=(-Db_lundef=false -Dfuzz-tests=true)
fi fi
meson --werror -Dtests=unsafe -Db_sanitize=address,undefined "${MESON_ARGS[@]}" build meson --werror -Dtests=unsafe -Db_sanitize=address,undefined "${MESON_ARGS[@]}" build
ninja -C build -v ninja -C build -v
@ -61,12 +63,17 @@ for phase in "${PHASES[@]}"; do
export ASAN_OPTIONS=strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1 export ASAN_OPTIONS=strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1
# Never remove halt_on_error from UBSAN_OPTIONS. See https://github.com/systemd/systemd/commit/2614d83aa06592aedb. # Never remove halt_on_error from UBSAN_OPTIONS. See https://github.com/systemd/systemd/commit/2614d83aa06592aedb.
export UBSAN_OPTIONS=print_stacktrace=1:print_summary=1:halt_on_error=1 export UBSAN_OPTIONS=print_stacktrace=1:print_summary=1:halt_on_error=1
# There's some weird stuff going on in GH Actions, where the following
# `meson test` command hangs after test #252 unless it's executed under # FIXME
# unbuffer or there's something else producing output. So far it happens # For some strange reason the GH Actions VM stops responding after
# _only_ with ASAn (not with UBSan), both with gcc and clang. I'll # executing first ~150 tests, _unless_ there's something producing
# need to take a closer look later... # output (either running `meson test` in verbose mode, or something
unbuffer meson test --timeout-multiplier=3 -C build --print-errorlogs # else in background). Despite my efforts so far I haven't been able
# to identify the culprit (since the issue is not reproducible
# during debugging, wonderful), so let's at least keep a workaround
# here to make the builds stable for the time being.
(set +x; while :; do echo -ne "\n[WATCHDOG] $(date)\n"; sleep 30; done) &
meson test --timeout-multiplier=3 -C build --print-errorlogs
;; ;;
CLEANUP) CLEANUP)
info "Cleanup phase" info "Cleanup phase"

9
TODO
View File

@ -20,6 +20,15 @@ Janitorial Clean-ups:
Features: Features:
* importd: add ability download images for portabled + sysext
* importd: support image signature verification with PKCS#7 + OpenBSD signify
logic, as alternative to crummy gpg
* sd-boot: add service that automatically runs "bootctl update" on every boot,
in a graceful way, so that updated /usr trees automatically propagate into
updated boot loaders on reboot.
* add "systemd-analyze debug" + AttachDebugger= in unit files: The former * add "systemd-analyze debug" + AttachDebugger= in unit files: The former
specifies a command to execute; the latter specifies that an already running specifies a command to execute; the latter specifies that an already running
"systemd-analyze debug" instance shall be contacted and execution paused "systemd-analyze debug" instance shall be contacted and execution paused

View File

@ -251,16 +251,11 @@ sensor:modalias:acpi:KIOX000A*:dmi:*:svncube:pni1-TF:*
sensor:modalias:acpi:SMO8500*:dmi:*:svncube:pni7:* sensor:modalias:acpi:SMO8500*:dmi:*:svncube:pni7:*
ACCEL_MOUNT_MATRIX=1, 0, 0; 0, -1, 0; 0, 0, 1 ACCEL_MOUNT_MATRIX=1, 0, 0; 0, -1, 0; 0, 0, 1
# Cube i7 Stylus # Cube i7 Stylus, i7 Stylus I8L Model, i7 Book (i16) and Mix Plus (i18B)
sensor:modalias:acpi:KIOX000A*:dmi:*:svnCube:pni7Stylus:* sensor:modalias:acpi:KIOX000A*:dmi:*:svnCube:pni7Stylus:*
ACCEL_MOUNT_MATRIX=-1, 0, 0; 0, 1, 0; 0, 0, 1
# Cube i7 Book (i16)
sensor:modalias:acpi:KIOX000A*:dmi:*:svnCube:pni16:*
ACCEL_MOUNT_MATRIX=-1, 0, 0; 0, 1, 0; 0, 0, 1
# Cube i7 Stylus I8L Model
sensor:modalias:acpi:KIOX000A*:dmi:*:svnCube:pni8-L:* sensor:modalias:acpi:KIOX000A*:dmi:*:svnCube:pni8-L:*
sensor:modalias:acpi:KIOX000A*:dmi:*:svnCube:pni16:*
sensor:modalias:acpi:KIOX000A*:dmi:*:svnCube:pni18B:*
ACCEL_MOUNT_MATRIX=-1, 0, 0; 0, 1, 0; 0, 0, 1 ACCEL_MOUNT_MATRIX=-1, 0, 0; 0, 1, 0; 0, 0, 1
# Cube iWork 10 Flagship # Cube iWork 10 Flagship

View File

@ -897,8 +897,8 @@ int main(int argc, char *argv[]) {
test_setup_logging(LOG_DEBUG); test_setup_logging(LOG_DEBUG);
#if HAS_FEATURE_ADDRESS_SANITIZER #if HAS_FEATURE_ADDRESS_SANITIZER
if (strstr_ptr(ci_environment(), "travis")) { if (strstr_ptr(ci_environment(), "travis") || strstr_ptr(ci_environment(), "github-actions")) {
log_notice("Running on TravisCI under ASan, skipping, see https://github.com/systemd/systemd/issues/10696"); log_notice("Running on Travis CI/GH Actions under ASan, skipping, see https://github.com/systemd/systemd/issues/10696");
return EXIT_TEST_SKIP; return EXIT_TEST_SKIP;
} }
#endif #endif